darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make sure partials always have a wrapping <div>

Browse Source 
The diffDOM Javascript sometimes throws an error if it can’t calculate
a diff between the original content of the page and the updated HTML
delivered via AJAX. The problem seems to be when there’s not one,
consistent top-level element for it to base its calculations on.

This commit:
- makes sure that all AJAX-delivered partials have a wrapping `<div>`
- that this `<div>` has a consistent class name to make it clear why
  it’s there
This commit is contained in:
Chris Hill-Scott
2016-09-01 11:06:52 +01:00
parent 0967706aed
commit 8c8f321a11
6 changed files with 67 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/dashboard/_usage.html
View File

@@ -1,6 +1,6 @@
{% from "components/big-number.html" import big_number %}
<div class='grid-row'>
<div class='grid-row ajax-block-container'>
<div class='column-half'>
<div class="keyline-block">
{{ big_number("Unlimited", 'free email allowance', smaller=True) }}