From 8c30dbfb69cf93f7caa6e9407066b05a40a5bd14 Mon Sep 17 00:00:00 2001 From: Katie Smith Date: Mon, 9 Mar 2020 14:17:20 +0000 Subject: [PATCH] Add international_letters permission to settings page This is a permission that can only be toggled by Platform Admin and which requires the `letter` permission in order to be turned on. --- app/main/views/service_settings.py | 1 + .../service_settings/test_service_setting_permissions.py | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/app/main/views/service_settings.py b/app/main/views/service_settings.py index 0c1f7b534..614f861d9 100644 --- a/app/main/views/service_settings.py +++ b/app/main/views/service_settings.py @@ -68,6 +68,7 @@ PLATFORM_ADMIN_SERVICE_PERMISSIONS = OrderedDict([ ('inbound_sms', {'title': 'Receive inbound SMS', 'requires': 'sms', 'endpoint': '.service_set_inbound_number'}), ('email_auth', {'title': 'Email authentication'}), ('upload_letters', {'title': 'Uploading letters', 'requires': 'letter'}), + ('international_letters', {'title': 'Send international letters', 'requires': 'letter'}), ]) diff --git a/tests/app/main/views/service_settings/test_service_setting_permissions.py b/tests/app/main/views/service_settings/test_service_setting_permissions.py index c6dc24cfd..5154a14d5 100644 --- a/tests/app/main/views/service_settings/test_service_setting_permissions.py +++ b/tests/app/main/views/service_settings/test_service_setting_permissions.py @@ -42,6 +42,8 @@ def test_service_set_permission_requires_platform_admin( ('inbound_sms', 'False', False), ('email_auth', 'True', True), ('email_auth', 'False', False), + ('international_letters', 'True', True), + ('international_letters', 'False', False), ]) def test_service_set_permission( mocker, @@ -70,6 +72,8 @@ def test_service_set_permission( ({'permissions': ['sms']}, '.service_set_inbound_number', {}, 'Receive inbound SMS Off Change'), ({'permissions': ['letter']}, '.service_set_permission', {'permission': 'upload_letters'}, 'Uploading letters Off Change'), + ({'permissions': ['letter']}, + '.service_set_permission', {'permission': 'international_letters'}, 'Send international letters Off Change'), ]) def test_service_setting_toggles_show(get_service_settings_page, service_one, service_fields, endpoint, kwargs, text): link_url = url_for(endpoint, **kwargs, service_id=service_one['id'])