darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove temporary raw_response argument

Browse Source 
We added a new argument to `client_request.get` and
`client_request.post` to specify that it should return a raw `Response`
object rather than an instance of `BeautifulSoup`.

This is useful because sometimes we need to look at stuff like the
response headers.

However it turns out we already have a separate method for this, so
rather than invent something new I think it’s better to stick with the
thing we already have.
This commit is contained in:
Chris Hill-Scott
2021-12-31 12:16:12 +00:00
parent c37258fd0d
commit 8b93a977a0
11 changed files with 27 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/app/main/views/test_platform_admin.py
View File

@@ -846,9 +846,8 @@ def test_get_live_services_report(
]}
)
client_request.login(platform_admin_user)
response = client_request.get(
response = client_request.get_response(
'main.live_services_csv',
_raw_response=True,
)
report = response.get_data(as_text=True)
assert report.strip() == (
@@ -943,11 +942,10 @@ def test_get_billing_report_when_calls_api_and_download_data(
)
client_request.login(platform_admin_user)
response = client_request.post(
response = client_request.post_response(
'main.get_billing_report',
_data={'start_date': '2019-01-01', 'end_date': '2019-03-31'},
_expected_status=200,
_raw_response=True,
)
assert response.content_type == 'text/csv; charset=utf-8'
@@ -996,11 +994,10 @@ def test_get_notifications_sent_by_service_calls_api_and_downloads_data(
end_date = datetime.date(2019, 1, 31)
client_request.login(platform_admin_user)
response = client_request.post(
response = client_request.post_response(
'main.notifications_sent_by_service',
_data={'start_date': start_date, 'end_date': end_date},
_expected_status=200,
_raw_response=True,
)
assert response.content_type == 'text/csv; charset=utf-8'