darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop using _external=True in tests

Browse Source 
It looks like, by default, Flask no longer makes full URLs, for example
`https://example.com/path`. Instead it does `/path`. This will still
work fine, and if anything is better because it reduces the number of
bytes of HTML we are sending.

It won’t mean that requests go over `http` instead of `https` without
the protocol because we set the appropriate HSTS header here:
0c57da7781/ansible/roles/paas-proxy/templates/admin.conf.j2 (L11)

This commit changes all our tests to reflect that URLs no longer have
the protocol and domain in them. `_external=True` is Flask’s way of
saying whether a URL should be generated with the domain and protocol
(`True`) or without it (`False`).

Again, I can’t find the changelog or diff where this was introuduced,
but if you’d like to go spelunking then here’s a starting point:
50374e3cfe/src/flask/helpers.py (L192)
This commit is contained in:
Chris Hill-Scott
2022-05-27 14:46:35 +01:00
parent 5b5d4af681
commit 8b7f2fbf04
38 changed files with 83 additions and 251 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/app/main/views/test_verify.py
View File

@@ -48,7 +48,7 @@ def test_should_redirect_to_add_service_when_sms_code_is_correct(
client_request.post(
'main.verify',
_data={'sms_code': '12345'},
_expected_redirect=url_for('main.add_service', first='first', _external=True),
_expected_redirect=url_for('main.add_service', first='first'),
)
# make sure the current_session_id has changed to what the API returned
@@ -113,7 +113,7 @@ def test_verify_email_redirects_to_verify_if_token_valid(
client_request.get(
'main.verify_email',
token='notreal',
_expected_redirect=url_for('main.verify', _external=True),
_expected_redirect=url_for('main.verify'),
)
assert not mock_check_verify_code.called
@@ -140,7 +140,7 @@ def test_verify_email_doesnt_verify_sms_if_user_on_email_auth(
client_request.get(
'main.verify_email',
token='notreal',
_expected_redirect=url_for('main.add_service', first='first', _external=True),
_expected_redirect=url_for('main.add_service', first='first'),
)
assert not mock_check_verify_code.called
@@ -164,7 +164,7 @@ def test_verify_email_redirects_to_email_sent_if_token_expired(
client_request.get(
'main.verify_email',
token='notreal',
_expected_redirect=url_for('main.resend_email_verification', _external=True),
_expected_redirect=url_for('main.resend_email_verification'),
)
@@ -193,7 +193,7 @@ def test_verify_redirects_to_sign_in_if_not_logged_in(
client_request.logout()
client_request.get(
'main.verify',
_expected_redirect=url_for('main.sign_in', _external=True),
_expected_redirect=url_for('main.sign_in'),
)