mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-08 04:28:25 -04:00
Stop using _external=True in tests
It looks like, by default, Flask no longer makes full URLs, for example `https://example.com/path`. Instead it does `/path`. This will still work fine, and if anything is better because it reduces the number of bytes of HTML we are sending. It won’t mean that requests go over `http` instead of `https` without the protocol because we set the appropriate HSTS header here:0c57da7781/ansible/roles/paas-proxy/templates/admin.conf.j2 (L11)This commit changes all our tests to reflect that URLs no longer have the protocol and domain in them. `_external=True` is Flask’s way of saying whether a URL should be generated with the domain and protocol (`True`) or without it (`False`). Again, I can’t find the changelog or diff where this was introuduced, but if you’d like to go spelunking then here’s a starting point:50374e3cfe/src/flask/helpers.py (L192)
This commit is contained in:
@@ -12,7 +12,6 @@ def test_render_sign_out_redirects_to_sign_in(
|
||||
'main.sign_out',
|
||||
_expected_redirect=url_for(
|
||||
'main.index',
|
||||
_external=True,
|
||||
)
|
||||
)
|
||||
with client_request.session_transaction() as session:
|
||||
@@ -48,7 +47,6 @@ def test_sign_out_user(
|
||||
_expected_status=302,
|
||||
_expected_redirect=url_for(
|
||||
'main.index',
|
||||
_external=True,
|
||||
)
|
||||
)
|
||||
with client_request.session_transaction() as session:
|
||||
|
||||
Reference in New Issue
Block a user