darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Standardise when we clear template cache

Browse Source 
This is consistent with all other methods: we clear the cache after
the actual change, not before it.

Since the new version of -utils, we're now catching redis exceptions
on delete, so this change has little effect on behaviour.
This commit is contained in:
Ben Thorner
2022-02-22 11:32:54 +00:00
parent 3f2b760efb
commit 8aabaf1f49
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/notify_client/service_api_client.py
View File

@@ -216,8 +216,9 @@ class ServiceAPIClient(NotifyAdminAPIClient):
}) })
data = _attach_current_user(data) data = _attach_current_user(data)
endpoint = "/service/{0}/template/{1}".format(service_id, id_) endpoint = "/service/{0}/template/{1}".format(service_id, id_)
ret = self.post(endpoint, data)
self._delete_template_cache_for_service(service_id) self._delete_template_cache_for_service(service_id)
return self.post(endpoint, data) return ret
@cache.delete('service-{service_id}-templates') @cache.delete('service-{service_id}-templates')
def redact_service_template(self, service_id, id_): def redact_service_template(self, service_id, id_):
@@ -311,8 +312,9 @@ class ServiceAPIClient(NotifyAdminAPIClient):
'archived': True 'archived': True
} }
data = _attach_current_user(data) data = _attach_current_user(data)
ret = self.post(endpoint, data=data)
self._delete_template_cache_for_service(service_id) self._delete_template_cache_for_service(service_id)
return self.post(endpoint, data=data) return ret
# Temp access of service history data. Includes service and api key history # Temp access of service history data. Includes service and api key history
def get_service_history(self, service_id): def get_service_history(self, service_id):