From 5bc652db9e5d31c0f4c1fe026d7c682a24dd9576 Mon Sep 17 00:00:00 2001 From: Kenneth Kehl <@kkehl@flexion.us> Date: Mon, 20 May 2024 07:13:19 -0700 Subject: [PATCH 1/2] change vulture rules in Makefile --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index eb6bb8131..fe27636d6 100644 --- a/Makefile +++ b/Makefile @@ -77,7 +77,7 @@ py-test: ## Run python unit tests .PHONY: dead-code dead-code: - poetry run vulture ./app --min-confidence=100 + poetry run vulture ./app ./notifications_utils --min-confidence=60 .PHONY: e2e-test e2e-test: export NEW_RELIC_ENVIRONMENT=test From 309c168f529f8c8763f448c33e404c9883a045c5 Mon Sep 17 00:00:00 2001 From: Kenneth Kehl <@kkehl@flexion.us> Date: Mon, 20 May 2024 11:18:31 -0700 Subject: [PATCH 2/2] revert back to 100% confidence level for vulture and add a comment --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fe27636d6..c6f02c3e7 100644 --- a/Makefile +++ b/Makefile @@ -76,8 +76,9 @@ py-test: ## Run python unit tests poetry run coverage html -d .coverage_cache .PHONY: dead-code -dead-code: - poetry run vulture ./app ./notifications_utils --min-confidence=60 +dead-code: ## 60% is our aspirational goal, but currently breaks the build + poetry run vulture ./app ./notifications_utils --min-confidence=100 + .PHONY: e2e-test e2e-test: export NEW_RELIC_ENVIRONMENT=test