From 8a5e7a00dcdcf766e2aab9ccb948206c68be3a96 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Fri, 25 Oct 2019 15:12:27 +0100 Subject: [PATCH] Remove min-height from sticky submit buttons It makes them get out of alignment with other things in sticky footers. The problem of buttons getting too close to the bottom of the window can be fixed with some min-height on the container instead. --- .../stylesheets/components/stick-at-top-when-scrolling.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/stylesheets/components/stick-at-top-when-scrolling.scss b/app/assets/stylesheets/components/stick-at-top-when-scrolling.scss index 3e5f7eb11..6c27bb445 100644 --- a/app/assets/stylesheets/components/stick-at-top-when-scrolling.scss +++ b/app/assets/stylesheets/components/stick-at-top-when-scrolling.scss @@ -43,6 +43,7 @@ $sticky-padding: $gutter * 2 / 3; transition: bottom 0.1s ease-out, box-shadow 1s ease-in-out; padding: $sticky-padding 0 $sticky-padding $gutter-half; margin-top: -$sticky-padding; + min-height: 40px; & + .js-stick-at-bottom-when-scrolling { margin-top: ($sticky-padding * 2) * -1; @@ -54,7 +55,6 @@ $sticky-padding: $gutter * 2 / 3; .page-footer { margin-bottom: 0; - min-height: 50px; } .page-footer-delete-link-without-button {