update testing

This commit is contained in:
Beverly Nguyen
2024-06-11 12:35:59 -07:00
parent 8407f5605b
commit 89bd835cd8
2 changed files with 15 additions and 19 deletions

View File

@@ -1893,26 +1893,22 @@ def app_with_socketio():
( (
SERVICE_ONE_ID, SERVICE_ONE_ID,
{"start_date": "2024-01-01", "days": 7}, {"start_date": "2024-01-01", "days": 7},
{"service_id": SERVICE_ONE_ID, "start_date": "2024-01-01", "days": 7} {"service_id": SERVICE_ONE_ID, "start_date": "2024-01-01", "days": 7},
), ),
( (
SERVICE_TWO_ID, SERVICE_TWO_ID,
{"start_date": "2023-06-01", "days": 7}, {"start_date": "2023-06-01", "days": 7},
{"service_id": SERVICE_TWO_ID, "start_date": "2023-06-01", "days": 7} {"service_id": SERVICE_TWO_ID, "start_date": "2023-06-01", "days": 7},
), ),
] ],
) )
def test_fetch_daily_stats( def test_fetch_daily_stats(
app_with_socketio, mocker, app_with_socketio, mocker, service_id, date_range, expected_call_args
service_id,
date_range,
expected_call_args
): ):
app, socketio = app_with_socketio app, socketio = app_with_socketio
mocker.patch( mocker.patch(
"app.main.views.dashboard.get_stats_date_range", "app.main.views.dashboard.get_stats_date_range", return_value=date_range
return_value=date_range
) )
mock_service_api = mocker.patch( mock_service_api = mocker.patch(
@@ -1920,9 +1916,9 @@ def test_fetch_daily_stats(
return_value={ return_value={
date_range["start_date"]: { date_range["start_date"]: {
"email": {"delivered": 0, "failure": 0, "requested": 0}, "email": {"delivered": 0, "failure": 0, "requested": 0},
"sms": {"delivered": 0, "failure": 1, "requested": 1} "sms": {"delivered": 0, "failure": 1, "requested": 1},
}, },
} },
) )
client = SocketIOTestClient(app, socketio) client = SocketIOTestClient(app, socketio)
@@ -1930,22 +1926,22 @@ def test_fetch_daily_stats(
connected = client.is_connected() connected = client.is_connected()
assert connected, "Client should be connected" assert connected, "Client should be connected"
client.emit('fetch_daily_stats', service_id) client.emit("fetch_daily_stats", service_id)
received = client.get_received() received = client.get_received()
assert received, "Should receive a response message" assert received, "Should receive a response message"
assert received[0]['name'] == 'daily_stats_update' assert received[0]["name"] == "daily_stats_update"
assert received[0]['args'][0] == { assert received[0]["args"][0] == {
date_range["start_date"]: { date_range["start_date"]: {
"email": {"delivered": 0, "failure": 0, "requested": 0}, "email": {"delivered": 0, "failure": 0, "requested": 0},
"sms": {"delivered": 0, "failure": 1, "requested": 1} "sms": {"delivered": 0, "failure": 1, "requested": 1},
}, },
} }
mock_service_api.assert_called_once_with( mock_service_api.assert_called_once_with(
service_id, service_id,
start_date=expected_call_args["start_date"], start_date=expected_call_args["start_date"],
days=expected_call_args["days"] days=expected_call_args["days"],
) )
finally: finally:
client.disconnect() client.disconnect()

View File

@@ -19,9 +19,9 @@ def test_non_logged_in_user_can_see_homepage(
"Reach people where they are with government-powered text messages" "Reach people where they are with government-powered text messages"
) )
assert page.select_one("a.usa-button.usa-button--big")["href"] == url_for( assert page.select_one(
"main.sign_in", "a.usa-button.login-button.login-button--primary.margin-right-2"
) )["href"]
assert page.select_one("meta[name=description]") is not None assert page.select_one("meta[name=description]") is not None
# This area is hidden for the pilot # This area is hidden for the pilot