darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Ensure all Javascript is served compressed

Browse Source 
Previously we were running the minification before adding dependencies.
This meant that dependencies that don’t come with a minified version
were being served in full.

Running Uglify over everything _after_ including the dependencies
reduces the weight of the downloaded Javascript by about 50kb.
This commit is contained in:
Chris Hill-Scott
2016-10-08 13:31:19 +01:00
parent 14c9f39342
commit 87fc3a9e16
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gulpfile.babel.js
View File

@@ -69,7 +69,6 @@ gulp.task('javascripts', () => gulp
.pipe(plugins.babel({ .pipe(plugins.babel({
presets: ['es2015'] presets: ['es2015']
})) }))
.pipe(plugins.uglify())
.pipe(plugins.addSrc.prepend([ .pipe(plugins.addSrc.prepend([
paths.npm + 'hogan.js/dist/hogan-3.0.2.js', paths.npm + 'hogan.js/dist/hogan-3.0.2.js',
paths.npm + 'jquery/dist/jquery.min.js', paths.npm + 'jquery/dist/jquery.min.js',
@@ -77,6 +76,7 @@ gulp.task('javascripts', () => gulp
paths.npm + 'diff-dom/diffDOM.js', paths.npm + 'diff-dom/diffDOM.js',
paths.npm + 'timeago/jquery.timeago.js' paths.npm + 'timeago/jquery.timeago.js'
])) ]))
.pipe(plugins.uglify())
.pipe(plugins.concat('all.js')) .pipe(plugins.concat('all.js'))
.pipe(gulp.dest(paths.dist + 'javascripts/')) .pipe(gulp.dest(paths.dist + 'javascripts/'))
); );