Move the ‘estimated usage’ questions

We get a bunch of requests to go live where people have told us they're
going to send email but there is no email reply-to address present.

These come from 2 scenarios:

1. when there are email templates, and no reply to address – but they
   ignore the checklist
2. when there are no email templates (yet) but they provide anticipated
   volumes for email

At the moment we only auto-check for a reply to address when they have
email templates. And because the question about anticipated volumes
follows the checklist, you'll get a checklist that passes (reply
addresses not required as no templates present) - but your future intent
that differs (reply address IS required because you have anticipated
volumes).

So let’s bring the request for anticipated volumes into the checklist,
that way we can dynamically add the requirement for a reply to address
if they say they will send email but don't have templates yet.

We should begin storing it in the database against the service to stop
people having to re-enter it each time they try to complete the go live
screens.

This also means moving the ‘consent to research question’ along with
the questions about volume, because
- we want people to answer both before going live
- we don’t want to clutter up the summary page by asking questions there
  too
This commit is contained in:
Chris Hill-Scott
2019-02-15 11:03:19 +00:00
parent cc16ab652a
commit 8791134c60
9 changed files with 282 additions and 118 deletions

View File

@@ -84,6 +84,10 @@ class ServiceAPIClient(NotifyAdminAPIClient):
'free_sms_fragment_limit',
'prefix_sms',
'contact_link',
'volume_email',
'volume_sms',
'volume_letter',
'consent_to_research',
}
if disallowed_attributes:
raise TypeError('Not allowed to update service attributes: {}'.format(