From fbd2102832654be39a75928aff13d4179bfc927c Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 23 Aug 2018 14:15:16 +0100 Subject: [PATCH 1/4] Use task list pattern for request to go live MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We’ve found a significant property of users (about 25%) who request to go live aren’t completing all the items on the checklist. In 1 of 6 (17%) of the usability testing sessions we did on this process we saw someone skip straight past the checklist page because of big green button syndrome. While 1 in 6 people would normally be a small number[1] in the context of a usability testing session, it’s enough to cause a big workload for our team (assuming it is the sole cause of people not completing the items on the checklist). The initial reason for using the tick cross pattern for the checklist was: - it was coherent with the rest of Notify - the task list pattern didn’t have a way of showing that something still needed doing – it put more visual emphasis on the things the user had already done There’s been some interesting discussion on the GOV.UK Design System backlog about users failing to complete items in the task list. A few people have tried different patterns for communicating that items in the task list still need ‘completing’. So this commit: - adds a task list pattern - uses the task list pattern for the request to go live checklist The task list is adapted from the one in the design system in that: - the ‘completed’ label has a black, not blue background (because Notify often uses blocks of blue to indicate something that’s clickable) - it adds an explicit ‘not complete’ label which is visually not filled in (sort of how ticked/unticket radio buttons work) 1. With the caveat that looking only at task completion, or quantifying qualitative not good practices and the intention here is to show that the numbers are close enough to say that they could be symptomatic of the same problem. Leisa Reichelt’s Mind the Product talk is good on this https://vimeo.com/284015765 --- .../stylesheets/components/task-list.scss | 41 +++++++++++++++++++ app/assets/stylesheets/main.scss | 1 + app/templates/components/task-list.html | 16 ++++++++ app/templates/components/tick-cross.html | 1 - .../service-settings/request-to-go-live.html | 20 ++++----- tests/app/main/views/test_service_settings.py | 16 ++++---- 6 files changed, 76 insertions(+), 19 deletions(-) create mode 100644 app/assets/stylesheets/components/task-list.scss create mode 100644 app/templates/components/task-list.html diff --git a/app/assets/stylesheets/components/task-list.scss b/app/assets/stylesheets/components/task-list.scss new file mode 100644 index 000000000..35f42eb15 --- /dev/null +++ b/app/assets/stylesheets/components/task-list.scss @@ -0,0 +1,41 @@ +$indicator-colour: $black; + +%task-list-indicator { + @include bold-16; + display: inline-block; + padding: 3px 8px 1px 8px; + position: absolute; + right: 0; + top: 50%; + margin-top: -15px; + border: 2px solid $indicator-colour; +} + +.task-list { + + border-bottom: 1px solid $border-colour; + margin: $gutter 0; + + &-item { + border-top: 1px solid $border-colour; + padding: 15px 0; + padding-right: 20%; + position: relative; + } + + &-indicator-completed { + @extend %task-list-indicator; + background-color: $indicator-colour; + color: $grey-4; + // Just a pinch of letter spacing to make reversed-out text a bit + // easier to read + letter-spacing: 0.02em; + } + + &-indicator-not-completed { + @extend %task-list-indicator; + background-color: transparent; + color: $indicator-colour; + } + +} diff --git a/app/assets/stylesheets/main.scss b/app/assets/stylesheets/main.scss index 9f5955cae..74e3784d5 100644 --- a/app/assets/stylesheets/main.scss +++ b/app/assets/stylesheets/main.scss @@ -62,6 +62,7 @@ $path: '/static/images/'; @import 'components/vendor/breadcrumbs'; @import 'components/vendor/responsive-embed'; @import 'components/email-preview-pane'; +@import 'components/task-list'; @import 'views/dashboard'; @import 'views/users'; diff --git a/app/templates/components/task-list.html b/app/templates/components/task-list.html new file mode 100644 index 000000000..38585ee54 --- /dev/null +++ b/app/templates/components/task-list.html @@ -0,0 +1,16 @@ +{% macro task_list_item(completed, label) %} +
  • + {{ label }} + {% if completed %} + Completed + {% else %} + Not completed + {% endif %} +
    • +{% endmacro %} + +{% macro task_list_wrapper() %} + +{% endmacro %} diff --git a/app/templates/components/tick-cross.html b/app/templates/components/tick-cross.html index f6fbc9ecf..d8c0c297d 100644 --- a/app/templates/components/tick-cross.html +++ b/app/templates/components/tick-cross.html @@ -14,7 +14,6 @@ {% endmacro %} - {% macro tick_cross_done_not_done(yes, label) %} {{ tick_cross(yes, label, truthy_hint='Done: ', falsey_hint='Not done: ') }} {% endmacro %} diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index 2833dac48..4858714ca 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -4,7 +4,7 @@ {% from "components/radios.html" import radios %} {% from "components/page-footer.html" import page_footer %} {% from "components/banner.html" import banner_wrapper %} -{% from "components/tick-cross.html" import tick_cross_done_not_done %} +{% from "components/task-list.html" import task_list_wrapper, task_list_item %} {% block service_page_title %} Request to go live @@ -15,30 +15,30 @@

    Request to go live

    - Before your service can go live on Notify, you’ll need to: + Before your service can go live on Notify, you need:

    - + {% endcall %}

    You also need to accept our terms of use.

    diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index b87f834bd..c26ab1194 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -503,19 +503,19 @@ def test_should_raise_duplicate_name_handled( @pytest.mark.parametrize('count_of_users_with_manage_service, expected_user_checklist_item', [ - (1, 'Not done: Have more than one team member with the ‘Manage service’ permission'), - (2, 'Done: Have more than one team member with the ‘Manage service’ permission'), + (1, 'More than one team member with the ‘Manage settings’ permission Not completed'), + (2, 'More than one team member with the ‘Manage settings’ permission Completed'), ]) @pytest.mark.parametrize('count_of_templates, expected_templates_checklist_item', [ - (0, 'Not done: Create templates showing the kind of messages you plan to send'), - (1, 'Done: Create templates showing the kind of messages you plan to send'), - (2, 'Done: Create templates showing the kind of messages you plan to send'), + (0, 'Templates showing the kind of messages you plan to send Not completed'), + (1, 'Templates showing the kind of messages you plan to send Completed'), + (2, 'Templates showing the kind of messages you plan to send Completed'), ]) @pytest.mark.parametrize('count_of_email_templates, reply_to_email_addresses, expected_reply_to_checklist_item', [ pytest.mark.xfail((0, [], ''), raises=IndexError), pytest.mark.xfail((0, [{}], ''), raises=IndexError), - (1, [], 'Not done: Add an email reply-to address'), - (1, [{}], 'Done: Add an email reply-to address'), + (1, [], 'An email reply-to address Not completed'), + (1, [{}], 'An email reply-to address Completed'), ]) def test_should_show_request_to_go_live_checklist( client_request, @@ -552,7 +552,7 @@ def test_should_show_request_to_go_live_checklist( ) assert page.h1.text == 'Request to go live' - checklist_items = page.select('main ul[class=bottom-gutter] li') + checklist_items = page.select('.task-list .task-list-item') assert normalize_spaces(checklist_items[0].text) == expected_user_checklist_item assert normalize_spaces(checklist_items[1].text) == expected_templates_checklist_item From 45eb16b4db67a173501af8d45a34081b55e8d59f Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 23 Aug 2018 16:11:08 +0100 Subject: [PATCH 2/4] Check text message sender before going live MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We often check that a service has an appropriate text message sender as a condition of them going live. We don’t mention this anywhere. The services for whom GOVUK is definitely not an appropriate sender are those in local government. As we have more of these teams starting to use Notify, we should streamline the process by making this check automated. This commit adds that check, for teams who: - have text message templates - have self-declared as NHS or local government --- app/main/views/service_settings.py | 20 +-- .../service-settings/request-to-go-live.html | 6 + app/utils.py | 8 ++ tests/app/main/views/test_service_settings.py | 114 +++++++++++++++++- 4 files changed, 140 insertions(+), 8 deletions(-) diff --git a/app/main/views/service_settings.py b/app/main/views/service_settings.py index e7c87f6a7..ef734e901 100644 --- a/app/main/views/service_settings.py +++ b/app/main/views/service_settings.py @@ -53,6 +53,7 @@ from app.utils import ( AgreementInfo, email_safe, get_cdn_domain, + get_default_sms_sender, user_has_permissions, user_is_platform_admin, ) @@ -83,10 +84,6 @@ def service_settings(service_id): (Field(x['contact_block'], html='escape') for x in letter_contact_details if x['is_default']), "Not set" ) sms_senders = service_api_client.get_sms_senders(service_id) - sms_sender_count = len(sms_senders) - default_sms_sender = next( - (Field(x['sms_sender'], html='escape') for x in sms_senders if x['is_default']), "None" - ) free_sms_fragment_limit = billing_api_client.get_free_sms_fragment_limit_for_year(service_id) data_retention = service_api_client.get_service_data_retention(service_id) @@ -103,8 +100,8 @@ def service_settings(service_id): reply_to_email_address_count=reply_to_email_address_count, default_letter_contact_block=default_letter_contact_block, letter_contact_details_count=letter_contact_details_count, - default_sms_sender=default_sms_sender, - sms_sender_count=sms_sender_count, + default_sms_sender=get_default_sms_sender(sms_senders), + sms_sender_count=len(sms_senders), free_sms_fragment_limit=free_sms_fragment_limit, prefix_sms=current_service.prefix_sms, organisation=organisation, @@ -192,9 +189,18 @@ def request_to_go_live(service_id): has_email_templates=( service_api_client.count_service_templates(service_id, template_type='email') > 0 ), + has_sms_templates=( + service_api_client.count_service_templates(service_id, template_type='sms') > 0 + ), has_email_reply_to_address=bool( service_api_client.get_reply_to_email_addresses(service_id) - ) + ), + shouldnt_use_govuk_as_sms_sender=( + current_service.organisation_type in {'local', 'nhs'} + ), + sms_sender_is_govuk=get_default_sms_sender( + service_api_client.get_sms_senders(service_id) + ) in {'GOVUK', 'None'}, ) diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index 4858714ca..fbd228fea 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -38,6 +38,12 @@ )|safe, ) }} {% endif %} + {% if has_sms_templates and shouldnt_use_govuk_as_sms_sender %} + {{ task_list_item( + not sms_sender_is_govuk, + 'Change your text message sender from GOVUK' + ) }} + {% endif %} {% endcall %}

    You also need to accept our terms of use. diff --git a/app/utils.py b/app/utils.py index ac3251bf4..0590dd585 100644 --- a/app/utils.py +++ b/app/utils.py @@ -25,6 +25,7 @@ from flask import ( url_for, ) from flask_login import current_user +from notifications_utils.field import Field from notifications_utils.formatters import make_quotes_smart from notifications_utils.recipients import RecipientCSV from notifications_utils.take import Take @@ -663,3 +664,10 @@ def should_skip_template_page(template_type): not current_user.has_permissions('manage_templates', 'manage_api_keys') and template_type != 'letter' ) + + +def get_default_sms_sender(sms_senders): + return str(next(( + Field(x['sms_sender'], html='escape') + for x in sms_senders if x['is_default'] + ), "None")) diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index c26ab1194..c7118e540 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -517,9 +517,13 @@ def test_should_raise_duplicate_name_handled( (1, [], 'An email reply-to address Not completed'), (1, [{}], 'An email reply-to address Completed'), ]) +@pytest.mark.parametrize('expected_sms_sender_item', [ + ('Templates showing the kind of messages you plan to send Not completed'), +]) def test_should_show_request_to_go_live_checklist( client_request, mocker, + single_sms_sender, count_of_users_with_manage_service, expected_user_checklist_item, count_of_templates, @@ -527,11 +531,13 @@ def test_should_show_request_to_go_live_checklist( count_of_email_templates, reply_to_email_addresses, expected_reply_to_checklist_item, + expected_sms_sender_item, ): def _count_templates(service_id, template_type=None): return { - 'email': count_of_email_templates + 'email': count_of_email_templates, + 'sms': 0, }.get(template_type, count_of_templates) mock_count_users = mocker.patch( @@ -567,12 +573,118 @@ def test_should_show_request_to_go_live_checklist( assert mock_count_templates.call_args_list == [ call(SERVICE_ONE_ID), call(SERVICE_ONE_ID, template_type='email'), + call(SERVICE_ONE_ID, template_type='sms'), ] if count_of_email_templates: mock_get_reply_to_email_addresses.assert_called_once_with(SERVICE_ONE_ID) +@pytest.mark.parametrize('organisation_type,count_of_sms_templates, sms_senders, expected_sms_sender_checklist_item', [ + pytest.mark.xfail(( + 'local', + 0, + [], + '', + ), raises=IndexError), + pytest.mark.xfail(( + 'local', + 0, + [{'is_default': True, 'sms_sender': 'GOVUK'}], + '', + ), raises=IndexError), + pytest.mark.xfail(( + None, + 99, + [{'is_default': True, 'sms_sender': 'GOVUK'}], + '', + ), raises=IndexError), + pytest.mark.xfail(( + 'central', + 99, + [{'is_default': True, 'sms_sender': 'GOVUK'}], + '', + ), raises=IndexError), + ( + 'local', + 1, + [], + 'Change your text message sender from GOVUK Not completed', + ), + ( + 'local', + 1, + [{'is_default': True, 'sms_sender': 'GOVUK'}], + 'Change your text message sender from GOVUK Not completed', + ), + ( + 'local', + 1, + [ + {'is_default': False, 'sms_sender': 'GOVUK'}, + {'is_default': True, 'sms_sender': 'KUVOG'}, + ], + 'Change your text message sender from GOVUK Completed', + ), + ( + 'nhs', + 1, + [{'is_default': True, 'sms_sender': 'KUVOG'}], + 'Change your text message sender from GOVUK Completed', + ), +]) +def test_should_check_for_sms_sender_on_go_live( + client_request, + service_one, + mocker, + organisation_type, + count_of_sms_templates, + sms_senders, + expected_sms_sender_checklist_item, +): + + service_one['organisation_type'] = organisation_type + + def _count_templates(service_id, template_type=None): + return { + 'email': 0, + 'sms': count_of_sms_templates, + }.get(template_type, count_of_sms_templates) + + mocker.patch( + 'app.main.views.service_settings.user_api_client.get_count_of_users_with_permission', + return_value=99, + ) + mock_count_templates = mocker.patch( + 'app.main.views.service_settings.service_api_client.count_service_templates', + side_effect=_count_templates, + ) + mock_get_sms_senders = mocker.patch( + 'app.main.views.service_settings.service_api_client.get_sms_senders', + return_value=sms_senders, + ) + mocker.patch( + 'app.main.views.service_settings.service_api_client.get_reply_to_email_addresses', + return_value=[], + ) + + page = client_request.get( + 'main.request_to_go_live', service_id=SERVICE_ONE_ID + ) + assert page.h1.text == 'Request to go live' + + checklist_items = page.select('.task-list .task-list-item') + assert normalize_spaces(checklist_items[2].text) == expected_sms_sender_checklist_item + + assert mock_count_templates.call_args_list == [ + call(SERVICE_ONE_ID), + call(SERVICE_ONE_ID, template_type='email'), + call(SERVICE_ONE_ID, template_type='sms'), + ] + + mock_get_sms_senders.assert_called_once_with(SERVICE_ONE_ID) + + def test_should_show_request_to_go_live( client_request, ): From 7c6627254b2e4269652097b91df257ec96045e22 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 29 Aug 2018 10:19:58 +0100 Subject: [PATCH 3/4] Update content to work in task list pattern We probably don't need to use a lead-in for a task list / table. Also moves the line about making the service live within one day to the next screen. --- .../service-settings/request-to-go-live.html | 22 ++++++------- .../submit-request-to-go-live.html | 8 +++-- tests/app/main/views/test_service_settings.py | 32 ++++++++----------- 3 files changed, 30 insertions(+), 32 deletions(-) diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index fbd228fea..c967858a0 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -7,33 +7,32 @@ {% from "components/task-list.html" import task_list_wrapper, task_list_item %} {% block service_page_title %} - Request to go live + Before you request to go live {% endblock %} {% block maincolumn_content %}

    -

    Request to go live

    -

    - Before your service can go live on Notify, you need: -

    +

    Before you request to go live

    {% call task_list_wrapper() %} {{ task_list_item( has_team_members, - 'More than one team member with the ‘Manage settings’ permission'.format( + 'Add a team member who can manage settings, team and usage +'.format( url_for('main.manage_users', service_id=current_service.id) )|safe, ) }} {{ task_list_item( has_templates, - 'Templates showing the kind of messages you plan to send'.format( + 'Add content to +templates to show the kind of messages you’ll send'.format( url_for('main.choose_template', service_id=current_service.id) )|safe, ) }} {% if has_email_templates %} {{ task_list_item( has_email_reply_to_address, - 'An email reply-to address'.format( + 'Add an email reply-to address'.format( url_for('main.service_email_reply_to', service_id=current_service.id) )|safe, ) }} @@ -41,16 +40,15 @@ {% if has_sms_templates and shouldnt_use_govuk_as_sms_sender %} {{ task_list_item( not sms_sender_is_govuk, - 'Change your text message sender from GOVUK' + 'Change your text message sender name'.format( + url_for('main.service_sms_senders', service_id=current_service.id) + )|safe ) }} {% endif %} {% endcall %}

    You also need to accept our terms of use.

    -

    - We’ll make your service live within one working day. -

    Continue

    diff --git a/app/templates/views/service-settings/submit-request-to-go-live.html b/app/templates/views/service-settings/submit-request-to-go-live.html index 517afd278..c6a352d11 100644 --- a/app/templates/views/service-settings/submit-request-to-go-live.html +++ b/app/templates/views/service-settings/submit-request-to-go-live.html @@ -6,12 +6,16 @@ {% from "components/banner.html" import banner_wrapper %} {% block service_page_title %} - How do you plan to use Notify? + Request to go live {% endblock %} {% block maincolumn_content %} -

    How do you plan to use Notify?

    +

    Request to go live

    + +

    + Tell us how you plan to use Notify. When we receive your request we’ll make your service live within one working day. +

    {{ checkbox_group('What kind of messages will you be sending?', [ diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index c7118e540..c1fa32ff8 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -503,22 +503,19 @@ def test_should_raise_duplicate_name_handled( @pytest.mark.parametrize('count_of_users_with_manage_service, expected_user_checklist_item', [ - (1, 'More than one team member with the ‘Manage settings’ permission Not completed'), - (2, 'More than one team member with the ‘Manage settings’ permission Completed'), + (1, 'Add a team member who can manage settings, team and usage Not completed'), + (2, 'Add a team member who can manage settings, team and usage Completed'), ]) @pytest.mark.parametrize('count_of_templates, expected_templates_checklist_item', [ - (0, 'Templates showing the kind of messages you plan to send Not completed'), - (1, 'Templates showing the kind of messages you plan to send Completed'), - (2, 'Templates showing the kind of messages you plan to send Completed'), + (0, 'Add content to templates to show the kind of messages you’ll send Not completed'), + (1, 'Add content to templates to show the kind of messages you’ll send Completed'), + (2, 'Add content to templates to show the kind of messages you’ll send Completed'), ]) @pytest.mark.parametrize('count_of_email_templates, reply_to_email_addresses, expected_reply_to_checklist_item', [ pytest.mark.xfail((0, [], ''), raises=IndexError), pytest.mark.xfail((0, [{}], ''), raises=IndexError), - (1, [], 'An email reply-to address Not completed'), - (1, [{}], 'An email reply-to address Completed'), -]) -@pytest.mark.parametrize('expected_sms_sender_item', [ - ('Templates showing the kind of messages you plan to send Not completed'), + (1, [], 'Add an email reply-to address Not completed'), + (1, [{}], 'Add an email reply-to address Completed'), ]) def test_should_show_request_to_go_live_checklist( client_request, @@ -531,7 +528,6 @@ def test_should_show_request_to_go_live_checklist( count_of_email_templates, reply_to_email_addresses, expected_reply_to_checklist_item, - expected_sms_sender_item, ): def _count_templates(service_id, template_type=None): @@ -556,7 +552,7 @@ def test_should_show_request_to_go_live_checklist( page = client_request.get( 'main.request_to_go_live', service_id=SERVICE_ONE_ID ) - assert page.h1.text == 'Request to go live' + assert page.h1.text == 'Before you request to go live' checklist_items = page.select('.task-list .task-list-item') @@ -609,13 +605,13 @@ def test_should_show_request_to_go_live_checklist( 'local', 1, [], - 'Change your text message sender from GOVUK Not completed', + 'Change your text message sender name Not completed', ), ( 'local', 1, [{'is_default': True, 'sms_sender': 'GOVUK'}], - 'Change your text message sender from GOVUK Not completed', + 'Change your text message sender name Not completed', ), ( 'local', @@ -624,13 +620,13 @@ def test_should_show_request_to_go_live_checklist( {'is_default': False, 'sms_sender': 'GOVUK'}, {'is_default': True, 'sms_sender': 'KUVOG'}, ], - 'Change your text message sender from GOVUK Completed', + 'Change your text message sender name Completed', ), ( 'nhs', 1, [{'is_default': True, 'sms_sender': 'KUVOG'}], - 'Change your text message sender from GOVUK Completed', + 'Change your text message sender name Completed', ), ]) def test_should_check_for_sms_sender_on_go_live( @@ -671,7 +667,7 @@ def test_should_check_for_sms_sender_on_go_live( page = client_request.get( 'main.request_to_go_live', service_id=SERVICE_ONE_ID ) - assert page.h1.text == 'Request to go live' + assert page.h1.text == 'Before you request to go live' checklist_items = page.select('.task-list .task-list-item') assert normalize_spaces(checklist_items[2].text) == expected_sms_sender_checklist_item @@ -691,7 +687,7 @@ def test_should_show_request_to_go_live( page = client_request.get( 'main.submit_request_to_go_live', service_id=SERVICE_ONE_ID ) - assert page.h1.text == 'How do you plan to use Notify?' + assert page.h1.text == 'Request to go live' for channel, label in ( ('email', 'Emails'), ('sms', 'Text messages'), From 06869ee2f3e91780a6873f8012660fdc7e2149a1 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 29 Aug 2018 11:04:53 +0100 Subject: [PATCH 4/4] Make the whole line a link This looks cleaner than having part of the line as a link, and because of the active opening word feels like more of a call to action. --- .../views/service-settings/request-to-go-live.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index c967858a0..f80287c1a 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -17,22 +17,22 @@ {% call task_list_wrapper() %} {{ task_list_item( has_team_members, - 'Add a team member who can manage settings, team and usage + 'Add a team member who can manage settings, team and usage '.format( url_for('main.manage_users', service_id=current_service.id) )|safe, ) }} {{ task_list_item( has_templates, - 'Add content to -templates to show the kind of messages you’ll send'.format( + 'Add content to +templates to show the kind of messages you’ll send'.format( url_for('main.choose_template', service_id=current_service.id) )|safe, ) }} {% if has_email_templates %} {{ task_list_item( has_email_reply_to_address, - 'Add an email reply-to address'.format( + 'Add an email reply-to address'.format( url_for('main.service_email_reply_to', service_id=current_service.id) )|safe, ) }} @@ -40,7 +40,7 @@ {% if has_sms_templates and shouldnt_use_govuk_as_sms_sender %} {{ task_list_item( not sms_sender_is_govuk, - 'Change your text message sender name'.format( + 'Change your text message sender name'.format( url_for('main.service_sms_senders', service_id=current_service.id) )|safe ) }}