darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 20:33:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop showing priorities for other provider types

Browse Source 
This isn't used and showing priorities when we only have a single
provider or where they have no effect is unnecessarily confusing.
Removing the form makes it clearer that there's only one way to
adjust priorities for domestic SMS providers.

If we add another email or international SMS provider in future,
we would need to rewrite the form here anyway as the priorities
need to be adjusted in tandem, not individually.
This commit is contained in:
Ben Thorner
2022-04-06 12:53:12 +01:00
parent 25a26c0b4d
commit 8655ab7dea
6 changed files with 9 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
app/templates/views/providers/edit-provider.html
View File

@@ -1,37 +0,0 @@
{% extends "withoutnav_template.html" %}
{% from "components/page-header.html" import page_header %}
{% from "components/page-footer.html" import page_footer %}
{% from "components/form.html" import form_wrapper %}
{% from "components/back-link/macro.njk" import govukBackLink %}
{% block per_page_title %}
{{provider.display_name}}
{% endblock %}
{% block backLink %}
{{ govukBackLink({ "href": url_for('.view_providers') }) }}
{% endblock %}
{% block maincolumn_content %}
<div class="govuk-grid-row">
<div class="govuk-grid-column-three-quarters">
{{ page_header(provider.display_name) }}
<p class="govuk-body">Update provider:</p>
<ul class="list-bullet">
<li>We only send from the highest priority provider</li>
</ul>
{% call form_wrapper() %}
{{ form.priority }}
{{ page_footer('Save') }}
{% endcall %}
</div>
</div>
{% endblock %}

11
app/templates/views/providers/providers.html
View File

@@ -48,14 +48,12 @@ Providers
caption="Email providers",
caption_visible=False,
empty_message='No email providers',
field_headings=['Provider', 'Priority', 'Active', 'Last Updated', 'Updated By'],
field_headings=['Provider', 'Active', 'Last Updated', 'Updated By'],
field_headings_visible=True
) %}
{{ link_field(item.display_name, url_for('main.view_provider', provider_id=item.id)) }}
{{ text_field(item.priority) }}
{{ text_field(item.active) }}
{% if item.updated_at %}
@@ -65,9 +63,6 @@ Providers
{% endif %}
{{ optional_text_field(item.created_by_name, default='None') }}
{{ link_field('change', url_for('main.edit_provider', provider_id=item.id)) }}
{% endcall %}
<h2 class="heading-medium">International SMS Providers</h2>
@@ -77,14 +72,12 @@ Providers
caption="International SMS providers",
caption_visible=False,
empty_message='No international sms providers',
field_headings=['Provider', 'Priority', 'Active', 'Last Updated', 'Updated By'],
field_headings=['Provider', 'Active', 'Last Updated', 'Updated By'],
field_headings_visible=True
) %}
{{ link_field(item.display_name, url_for('main.view_provider', provider_id=item.id)) }}
{{ text_field(item.priority) }}
{{ text_field(item.active) }}
{% if item.updated_at %}