darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 18:37:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicative test

Browse Source 
This case was already covered by `test_confirm_approve_non_training_broadcasts_errors_if_not_ticked`
This commit is contained in:
Chris Hill-Scott
2021-05-18 15:58:41 +01:00
parent e2ef8cd36e
commit 859674db38
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/app/main/views/test_broadcast.py
+7 -12
View File
@@ -2159,41 +2159,38 @@ def test_view_only_user_cant_approve_broadcast(
@pytest.mark.parametrize( @pytest.mark.parametrize(
'trial_mode, initial_status, post_data, expected_approval, expected_redirect, expected_status', 'trial_mode, initial_status, post_data, expected_approval, expected_redirect',
( (
(True, 'draft', {}, False, partial( (True, 'draft', {}, False, partial(
url_for, url_for,
'.view_current_broadcast', '.view_current_broadcast',
broadcast_message_id=sample_uuid, broadcast_message_id=sample_uuid,
), 302), )),
(True, 'pending-approval', {}, True, partial( (True, 'pending-approval', {}, True, partial(
url_for, url_for,
'.broadcast_tour', '.broadcast_tour',
step_index=6, step_index=6,
), 302), )),
(False, 'pending-approval', {}, False, (
lambda service_id, _external: None
), 200),
(False, 'pending-approval', {'confirm': 'y'}, True, partial( (False, 'pending-approval', {'confirm': 'y'}, True, partial(
url_for, url_for,
'.view_current_broadcast', '.view_current_broadcast',
broadcast_message_id=sample_uuid, broadcast_message_id=sample_uuid,
), 302), )),
(True, 'rejected', {}, False, partial( (True, 'rejected', {}, False, partial(
url_for, url_for,
'.view_current_broadcast', '.view_current_broadcast',
broadcast_message_id=sample_uuid, broadcast_message_id=sample_uuid,
), 302), )),
(True, 'broadcasting', {}, False, partial( (True, 'broadcasting', {}, False, partial(
url_for, url_for,
'.view_current_broadcast', '.view_current_broadcast',
broadcast_message_id=sample_uuid, broadcast_message_id=sample_uuid,
), 302), )),
(True, 'cancelled', {}, False, partial( (True, 'cancelled', {}, False, partial(
url_for, url_for,
'.view_current_broadcast', '.view_current_broadcast',
broadcast_message_id=sample_uuid, broadcast_message_id=sample_uuid,
), 302), )),
) )
) )
@freeze_time('2020-02-22T22:22:22.000000') @freeze_time('2020-02-22T22:22:22.000000')
@@ -2210,7 +2207,6 @@ def test_request_approval(
expected_approval, expected_approval,
trial_mode, trial_mode,
expected_redirect, expected_redirect,
expected_status,
): ):
mocker.patch( mocker.patch(
'app.broadcast_message_api_client.get_broadcast_message', 'app.broadcast_message_api_client.get_broadcast_message',
@@ -2234,7 +2230,6 @@ def test_request_approval(
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
_external=True, _external=True,
), ),
_expected_status=expected_status,
_data=post_data, _data=post_data,
) )