diff --git a/app/assets/stylesheets/components/tick-cross.scss b/app/assets/stylesheets/components/tick-cross.scss index 9d9ce2489..ef04b0a93 100644 --- a/app/assets/stylesheets/components/tick-cross.scss +++ b/app/assets/stylesheets/components/tick-cross.scss @@ -36,44 +36,10 @@ } - &-edit-link { - - text-align: right; - position: absolute; - top: -25px; - right: -135px; - - a { - - &:before { - content: ""; - display: block; - - position: absolute; - - top: -1 * govuk-spacing(3) - 1; - right: 0; - bottom: -1 * govuk-spacing(3); - left: -1 * govuk-spacing(3); - - background: transparent; - } - - &:active:before, - &:focus:before { - border-color: $yellow; - border-style: solid; - border-width: 15px 3px 15px 15px; - right: -3px; - } - - } - - } - &-hint { color: #6F777B; padding-top: 5px; + margin: 0; } } diff --git a/app/assets/stylesheets/views/users.scss b/app/assets/stylesheets/views/users.scss index 4abef1993..a30f04741 100644 --- a/app/assets/stylesheets/views/users.scss +++ b/app/assets/stylesheets/views/users.scss @@ -7,17 +7,14 @@ $item-top-padding: govuk-spacing(3); &-item { - padding: $item-top-padding 150px govuk-spacing(3) 0; + padding: govuk-spacing(3) 0px; border-top: 1px solid $border-colour; - position: relative; &-heading { padding-right: govuk-spacing(3); - white-space: nowrap; overflow: hidden; - text-overflow: ellipsis; - color: $secondary-text-colour; // So the ellipsis is grey + overflow-wrap: break-word; .heading-small { color: $black; @@ -29,13 +26,61 @@ $item-top-padding: govuk-spacing(3); border-bottom: 1px solid $border-colour; } + & :last-child { + margin-bottom: 0; + } + + &-blank { + + margin-bottom: govuk-spacing(3); + + @include govuk-media-query($from: tablet) { + margin-bottom: 0; + } + + } + } &-edit-link { - text-align: right; - position: absolute; - top: $item-top-padding; - right: 0px; + + position: relative; + display: block; + margin: govuk-spacing(3) 0 govuk-spacing(3); + + @include govuk-media-query($from: tablet) { + float: right; + margin: 0; + } + + &:before { + content: ""; + display: block; + + position: absolute; + + top: -1 * govuk-spacing(3) - 1; + right: 0; + bottom: -1 * govuk-spacing(3); + left: -1 * govuk-spacing(3); + + background: transparent; + } + + &:active:before, + &:focus:before { + border-color: $yellow; + border-style: solid; + border-width: 15px 3px; + right: -3px; + left: -3px; + + @include govuk-media-query($from: tablet) { + border-width: 15px 3px 15px 15px; + left: -15px; + } + } + } } diff --git a/app/templates/views/manage-users.html b/app/templates/views/manage-users.html index 663d8ccb5..f8c9d858b 100644 --- a/app/templates/views/manage-users.html +++ b/app/templates/views/manage-users.html @@ -22,33 +22,35 @@
{% for user in users %}
-

- {%- if user.name -%} - {{ user.name }}  - {%- endif -%} - - {%- if user.status == 'pending' -%} - {{ user.email_address }} (invited) - {%- elif user.status == 'cancelled' -%} - {{ user.email_address }} (cancelled invite) - {%- elif user.id == current_user.id -%} - (you) - {% else %} - {{ user.email_address }} - {% endif %} - -

- +
+
{% endfor %} diff --git a/app/templates/views/organisations/organisation/users/index.html b/app/templates/views/organisations/organisation/users/index.html index 7adb139f9..543bf1b6e 100644 --- a/app/templates/views/organisations/organisation/users/index.html +++ b/app/templates/views/organisations/organisation/users/index.html @@ -1,7 +1,6 @@ {% extends "org_template.html" %} {% from "components/table.html" import list_table, row, field, hidden_field_heading %} {% from "components/page-footer.html" import page_footer %} -{% from "components/tick-cross.html" import tick_cross %} {% from "components/textbox.html" import textbox %} {% from "components/live-search.html" import live_search %} {% from "components/button/macro.njk" import govukButton %} @@ -25,29 +24,31 @@
{% for user in users %}
-

- {%- if user.name -%} - {{ user.name }}  - {%- endif -%} - - {%- if user.status == 'pending' -%} - {{ user.email_address }} (invited) - {%- elif user.status == 'cancelled' -%} - {{ user.email_address }} (cancelled invite) - {%- elif user.id == current_user.id -%} - (you) - {% else %} - {{ user.email_address }} - {% endif %} - -

- +
+
{% endfor %} diff --git a/app/templates/views/service-settings/data-retention.html b/app/templates/views/service-settings/data-retention.html index d47e8cb49..ebd48ea76 100644 --- a/app/templates/views/service-settings/data-retention.html +++ b/app/templates/views/service-settings/data-retention.html @@ -29,27 +29,28 @@ By default data is kept for 7 days -
- {% if not current_service.data_retention %} + {% if not current_service.data_retention %} +
- You have not added any data retention +

You have not added any data retention

- {% endif %} - {% call mapping_table( - caption='Data retention', - field_headings=['Label', 'Value', 'Action'], - field_headings_visible=False, - caption_visible=False - ) %} - {% for item in current_service.data_retention %} - {% call row() %} - {{ text_field(item.notification_type | format_notification_type)}} - {{ text_field(item.days_of_retention) }} - {{ edit_field('Change', url_for('.edit_data_retention', service_id=current_service.id, data_retention_id=item.id)) }} - {% endcall %} +
+ {% else %} + {% call mapping_table( + caption='Data retention', + field_headings=['Label', 'Value', 'Action'], + field_headings_visible=False, + caption_visible=False + ) %} + {% for item in current_service.data_retention %} + {% call row() %} + {{ text_field(item.notification_type | format_notification_type)}} + {{ text_field(item.days_of_retention) }} + {{ edit_field('Change', url_for('.edit_data_retention', service_id=current_service.id, data_retention_id=item.id)) }} + {% endcall %} - {% endfor %} - {% endcall %} -
+ {% endfor %} + {% endcall %} + {% endif %} {% endblock %} diff --git a/app/templates/views/service-settings/email_reply_to.html b/app/templates/views/service-settings/email_reply_to.html index 60c88d6bb..958cba3ed 100644 --- a/app/templates/views/service-settings/email_reply_to.html +++ b/app/templates/views/service-settings/email_reply_to.html @@ -18,24 +18,34 @@
{% if not current_service.email_reply_to_addresses %}
- You have not added any reply-to email addresses yet +

You have not added any reply-to email addresses yet

{% endif %} {% for item in current_service.email_reply_to_addresses %}
-

- {{ item.email_address }} - {%- if item.is_default -%} - (default) +
+
+

+ {{ item.email_address }} + {%- if item.is_default -%} + (default) + {% endif %} + +

+
+
+ {% if current_user.has_permissions('manage_service') %} + Change {% endif %} - -

- {% if current_user.has_permissions('manage_service') %} - Change - {% endif %} - {% if current_service.count_email_reply_to_addresses > 1 %} - {{ api_key(item.id, name=item.email_address, thing="ID") }} - {% endif %} +
+
+
+
+ {% if current_service.count_email_reply_to_addresses > 1 %} + {{ api_key(item.id, name=item.email_address, thing="ID") }} + {% endif %} +
+
{% endfor %} diff --git a/app/templates/views/service-settings/letter-contact-details.html b/app/templates/views/service-settings/letter-contact-details.html index 0cf921156..a16ea0e1e 100644 --- a/app/templates/views/service-settings/letter-contact-details.html +++ b/app/templates/views/service-settings/letter-contact-details.html @@ -18,30 +18,41 @@
- - Blank - {% if current_service.default_letter_contact_block %} - {% if current_user.has_permissions('manage_service') %} - Make default +
+
+

+ Blank + {% if not current_service.default_letter_contact_block %} + (default) + {% endif %} +

+
+
+ {% if current_service.default_letter_contact_block and current_user.has_permissions('manage_service') %} + Make default {% endif %} - {% else %} - (default) - {% endif %} - +
+
{% for item in letter_contact_details %}
-

- {{ item.contact_block | nl2br }} -

-

- {%- if item.is_default -%} - (default) - {% endif %} -

- {% if current_user.has_permissions('manage_service') %} - Change - {% endif %} +
+
+

+ {{ item.contact_block | nl2br }} +

+

+ {%- if item.is_default -%} + (default) + {% endif %} +

+
+
+ {% if current_user.has_permissions('manage_service') %} + Change + {% endif %} +
+
{% if letter_contact_details|length > 1 %} {% set first_line_of_contact_block = item.contact_block|normalise_lines|first %} {{ api_key(item.id, name=first_line_of_contact_block, thing="ID") }} diff --git a/app/templates/views/service-settings/sms-senders.html b/app/templates/views/service-settings/sms-senders.html index aa7d9806f..20c84d646 100644 --- a/app/templates/views/service-settings/sms-senders.html +++ b/app/templates/views/service-settings/sms-senders.html @@ -18,23 +18,29 @@
{% if not current_service.sms_senders %}
- You have not added any text message senders yet +

You have not added any text message senders yet

{% endif %} {% for item in current_service.sms_senders_with_hints %}
-

- {{ item.sms_sender }} - {% if item.hint %} -   - - {{ item.hint }} - - {% endif %} -

- {% if current_user.has_permissions('manage_service') %} - Change - {% endif %} +
+
+

+ {{ item.sms_sender }} + {% if item.hint %} +   + + {{ item.hint }} + + {% endif %} +

+
+
+ {% if current_user.has_permissions('manage_service') %} + Change + {% endif %} +
+
{% if current_service.count_sms_senders > 1 %} {{ api_key(item.id, name=item.sms_sender, thing="ID") }} {% endif %} diff --git a/tests/app/main/views/organisations/test_organisation_invites.py b/tests/app/main/views/organisations/test_organisation_invites.py index d32748310..9a80301aa 100644 --- a/tests/app/main/views/organisations/test_organisation_invites.py +++ b/tests/app/main/views/organisations/test_organisation_invites.py @@ -28,7 +28,7 @@ def test_view_team_members( ) == 'Test User {}'.format(i + 1) assert normalize_spaces( - page.select('.tick-cross-list-edit-link')[0].text + page.select('.user-list-edit-link')[0].text ) == 'Cancel invitation'