From 84b02ee57adee5e679cda8da36049127d7c507fe Mon Sep 17 00:00:00 2001 From: Tom Byers Date: Fri, 26 Apr 2019 16:24:41 +0100 Subject: [PATCH] Remove reference to global 'this' from listEntry Also removes setting of the `$` variable to jQuery. This can mess up the unit tests if they run against JSDOM, which doesn't set the global `this` to `window`, as browsers do. We don't set `$` in any other module scripts and adding it to `this` without making explicit that `this` means `window` isn't useful. --- app/assets/javascripts/listEntry.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/assets/javascripts/listEntry.js b/app/assets/javascripts/listEntry.js index 07a5ffdfe..938a0a121 100644 --- a/app/assets/javascripts/listEntry.js +++ b/app/assets/javascripts/listEntry.js @@ -1,10 +1,6 @@ (function (Modules) { - 'use strict'; - var root = this, - $ = this.jQuery; - var lists = [], listEntry, ListEntry;