From 823c5a61194c4a9fbc22eb4c1bb25e2647a19290 Mon Sep 17 00:00:00 2001
From: Tom Byers <tombaromba@gmail.com>
Date: Mon, 22 Jul 2019 14:11:43 +0100
Subject: [PATCH] Add `clearEvents` method & refactor `setEvents`

`clearEvents` helps write the tests and also gives
users the opportunity to remove all of this
functionality.

Refactor of `setEvents` tidies up use of `self`.
---
 .../stick-to-window-when-scrolling.js         | 29 ++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/stick-to-window-when-scrolling.js b/app/assets/javascripts/stick-to-window-when-scrolling.js
index 0a3176beb..c75779109 100644
--- a/app/assets/javascripts/stick-to-window-when-scrolling.js
+++ b/app/assets/javascripts/stick-to-window-when-scrolling.js
@@ -710,21 +710,36 @@
     this.recalculate();
   };
   Sticky.prototype.setEvents = function () {
-    var self = this;
+    this._scrollEvent = this.onScroll.bind(this);
+    this._resizeEvent = this.onResize.bind(this);
 
     // flag when scrolling takes place and check (and re-position) sticky elements relative to
     // window position
-    if (self._scrollTimeout === false) {
-      $(global).scroll(function (e) { self.onScroll(); });
-      self._scrollTimeout = global.setInterval(function (e) { self.checkScroll(); }, 50);
+    if (this._scrollTimeout === false) {
+      $(global).scroll(this._scrollEvent);
+      this._scrollTimeout = global.setInterval(this.checkScroll.bind(this), 50);
     }
 
     // Recalculate all dimensions when the window resizes
-    if (self._resizeTimeout === false) {
-      $(global).resize(function (e) { self.onResize(); });
-      self._resizeTimeout = global.setInterval(function (e) { self.checkResize(); }, 50);
+    if (this._resizeTimeout === false) {
+      $(global).resize(this._resizeEvent);
+      this._resizeTimeout = global.setInterval(this.checkResize.bind(this), 50);
     }
   };
+  Sticky.prototype.clearEvents = function () {
+    if (this._scrollTimeout !== false) {
+      $(global).off('scroll', this._scrollEvent);
+      global.clearInterval(this._scrollTimeout);
+      this._scrollTimeout = false;
+    }
+
+    if (this._resizeTimeout !== false) {
+      $(global).off('resize', this._resizeEvent);
+      global.clearInterval(this._resizeTimeout);
+      this._resizeTimeout = false;
+    }
+
+  };
   Sticky.prototype.viewportIsWideEnough = function (windowWidth) {
     return windowWidth > 768;
   };