From 808f248782177f630cad946cfb1d9ffce450d767 Mon Sep 17 00:00:00 2001
From: Ben Thorner <ben.thorner@digital.cabinet-office.gov.uk>
Date: Thu, 24 Mar 2022 12:58:08 +0000
Subject: [PATCH] Rename "page-footer-delete-link" class

This doesn't set any deletion-specific attributes so it's valid to
just call it "page-footer-link".
---
 app/assets/stylesheets/components/page-footer.scss       | 2 +-
 app/templates/components/page-footer.html                | 2 +-
 app/templates/views/find-users/user-information.html     | 2 +-
 app/templates/views/jobs/job.html                        | 2 +-
 app/templates/views/service-settings.html                | 9 +++++----
 app/templates/views/templates/template.html              | 4 ++--
 .../views/uploads/contact-list/contact-list.html         | 2 +-
 .../service_settings/test_service_setting_permissions.py | 2 +-
 tests/app/main/views/test_service_settings.py            | 2 +-
 9 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/app/assets/stylesheets/components/page-footer.scss b/app/assets/stylesheets/components/page-footer.scss
index c1874c397..7d0552d14 100644
--- a/app/assets/stylesheets/components/page-footer.scss
+++ b/app/assets/stylesheets/components/page-footer.scss
@@ -3,7 +3,7 @@
   position: relative;
   margin-bottom: 30px;
 
-  &-delete-link {
+  &-link {
 
     line-height: 40px;
     padding: 1px 0 0 15px;
diff --git a/app/templates/components/page-footer.html b/app/templates/components/page-footer.html
index 789318ae7..c4948e4e6 100644
--- a/app/templates/components/page-footer.html
+++ b/app/templates/components/page-footer.html
@@ -31,7 +31,7 @@
 
     {% endif %}
     {% if delete_link %}
-      <span class="page-footer-delete-link {% if not button_text %}page-footer-delete-link-without-button{% endif %}">
+      <span class="page-footer-link {% if not button_text %}page-footer-delete-link-without-button{% endif %}">
         <a class="govuk-link govuk-link--destructive" href="{{ delete_link }}">{{ delete_link_text }}</a>
       </span>
     {% endif %}
diff --git a/app/templates/views/find-users/user-information.html b/app/templates/views/find-users/user-information.html
index c488856e7..fcc46266e 100644
--- a/app/templates/views/find-users/user-information.html
+++ b/app/templates/views/find-users/user-information.html
@@ -71,7 +71,7 @@
       </p>
       {% endif %}
       {% if user.state == 'active' %}
-        <span class="page-footer-delete-link page-footer-delete-link-without-button">
+        <span class="page-footer-link page-footer-delete-link-without-button">
           <a class="govuk-link govuk-link--destructive" href="{{ url_for('main.archive_user', user_id=user.id) }}">
             Archive user
           </a>
diff --git a/app/templates/views/jobs/job.html b/app/templates/views/jobs/job.html
index 131ee6b74..19277d36c 100644
--- a/app/templates/views/jobs/job.html
+++ b/app/templates/views/jobs/job.html
@@ -30,7 +30,7 @@
     {% if job.letter_job_can_be_cancelled %}
       <div class="js-stick-at-bottom-when-scrolling">
         <div class="page-footer">
-          <span class="page-footer-delete-link page-footer-delete-link-without-button">
+          <span class="page-footer-link page-footer-delete-link-without-button">
             <a class="govuk-link govuk-link--destructive" href="{{ url_for('main.cancel_letter_job', service_id=current_service.id, job_id=job.id) }}">Cancel sending these letters</a>
           </span>
     {% else %}
diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html
index 633565acb..5320a617c 100644
--- a/app/templates/views/service-settings.html
+++ b/app/templates/views/service-settings.html
@@ -460,14 +460,14 @@
 
     {% if current_service.active and (current_service.trial_mode or current_user.platform_admin) %}
       <p class="top-gutter-1-2">
-        <span class="page-footer-delete-link page-footer-delete-link-without-button">
+        <span class="page-footer-link page-footer-delete-link-without-button">
           <a class="govuk-link govuk-link--destructive" href="{{ url_for('.archive_service', service_id=current_service.id) }}">
             Delete this service
           </a>
         </span>
         {% if current_user.platform_admin %}
-          <span class="page-footer-delete-link">
-            <a href="{{ url_for('.suspend_service', service_id=current_service.id) }}" class="govuk-link govuk-link--destructive page-footer-delete-link">
+          <span class="page-footer-link">
+            <a href="{{ url_for('.suspend_service', service_id=current_service.id) }}" class="govuk-link govuk-link--destructive page-footer-link">
                 Suspend service
               </a>
           </span>
@@ -479,7 +479,8 @@
         <div class="hint bottom-gutter-1-2">
           Service suspended
         </div>
-        <span class="page-footer-delete-link page-footer-delete-link-without-button">
+
+        <span class="page-footer-link page-footer-delete-link-without-button">
           <a class="govuk-link govuk-link--destructive" href="{{ url_for('.resume_service', service_id=current_service.id) }}">
             Resume service
           </a>
diff --git a/app/templates/views/templates/template.html b/app/templates/views/templates/template.html
index 5e05a9761..a35ec9e4c 100644
--- a/app/templates/views/templates/template.html
+++ b/app/templates/views/templates/template.html
@@ -67,14 +67,14 @@
     {% endif %}
     {% if current_user.has_permissions('manage_templates') and user_has_template_permission %}
       {% if not template._template.archived %}
-        <span class="page-footer-delete-link page-footer-delete-link-without-button bottom-gutter-2-3">
+        <span class="page-footer-link page-footer-delete-link-without-button bottom-gutter-2-3">
           <a class="govuk-link govuk-link--destructive" href="{{ url_for('.delete_service_template', service_id=current_service.id, template_id=template.id) }}">Delete this template</a>
         </span>
         &emsp;
       {% endif %}
       {% if template.template_type not in ('letter', 'broadcast') %}
         {% if not template._template.redact_personalisation %}
-          <span class="page-footer-delete-link page-footer-delete-link-without-button">
+          <span class="page-footer-link page-footer-delete-link-without-button">
             <a class="govuk-link govuk-link--destructive" href="{{ url_for('.confirm_redact_template', service_id=current_service.id, template_id=template.id) }}">Hide personalisation after sending</a>
           </span>
         {% else %}
diff --git a/app/templates/views/uploads/contact-list/contact-list.html b/app/templates/views/uploads/contact-list/contact-list.html
index 8f627ea9f..89f126a94 100644
--- a/app/templates/views/uploads/contact-list/contact-list.html
+++ b/app/templates/views/uploads/contact-list/contact-list.html
@@ -130,7 +130,7 @@
   <div class="js-stick-at-bottom-when-scrolling">
     <div class="page-footer">
       {% if not confirm_delete_banner %}
-        <span class="page-footer-delete-link page-footer-delete-link-without-button">
+        <span class="page-footer-link page-footer-delete-link-without-button">
           <a class="govuk-link govuk-link--destructive" href="{{ url_for('main.delete_contact_list', service_id=current_service.id, contact_list_id=contact_list.id) }}">Delete this contact list</a>
         </span>
       {% endif %}
diff --git a/tests/app/main/views/service_settings/test_service_setting_permissions.py b/tests/app/main/views/service_settings/test_service_setting_permissions.py
index 7d6371ccc..6712463b0 100644
--- a/tests/app/main/views/service_settings/test_service_setting_permissions.py
+++ b/tests/app/main/views/service_settings/test_service_setting_permissions.py
@@ -168,7 +168,7 @@ def test_service_setting_link_toggles(
     link_url = url_for(endpoint, service_id=service_one['id'])
     service_one.update(service_fields)
     page = get_service_settings_page()
-    link = page.select('.page-footer-delete-link a')[index]
+    link = page.select('.page-footer-link a')[index]
     assert normalize_spaces(link.text) == text
     assert link['href'] == link_url
 
diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py
index 2f52ba349..472dc113b 100644
--- a/tests/app/main/views/test_service_settings.py
+++ b/tests/app/main/views/test_service_settings.py
@@ -4181,7 +4181,7 @@ def test_archive_service_prompts_user(
         'main.archive_service',
         service_id=SERVICE_ONE_ID
     )
-    delete_link = settings_page.select('.page-footer-delete-link a')[0]
+    delete_link = settings_page.select('.page-footer-link a')[0]
     assert normalize_spaces(delete_link.text) == 'Delete this service'
     assert delete_link['href'] == url_for(
         'main.archive_service',