From 80339046dfb3abacece547d1b83231a5b26d7510 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 30 Aug 2018 10:48:44 +0100 Subject: [PATCH] Remove question about which features people use MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is an optional question. We don’t really use the answer to it now that we have some adoption of all these features. --- app/main/forms.py | 3 --- app/main/views/service_settings.py | 6 ------ .../service-settings/submit-request-to-go-live.html | 5 ----- tests/app/main/views/test_service_settings.py | 12 ------------ 4 files changed, 26 deletions(-) diff --git a/app/main/forms.py b/app/main/forms.py index 6cec88500..794f8e322 100644 --- a/app/main/forms.py +++ b/app/main/forms.py @@ -584,9 +584,6 @@ class RequestToGoLiveForm(StripWhitespaceForm): 'Will the number of messages increase and when will that start?', validators=[DataRequired(message='Can’t be empty')] ) - method_one_off = BooleanField('One at a time') - method_upload = BooleanField('Upload a spreadsheet of recipients') - method_api = BooleanField('Integrate with the GOV.UK Notify API') class ProviderForm(StripWhitespaceForm): diff --git a/app/main/views/service_settings.py b/app/main/views/service_settings.py index 1c4e7c0fd..9dd4aaee3 100644 --- a/app/main/views/service_settings.py +++ b/app/main/views/service_settings.py @@ -224,7 +224,6 @@ def submit_request_to_go_live(service_id): '\nAgreement signed: {}' '\nChannel: {}\nStart date: {}\nStart volume: {}' '\nPeak volume: {}' - '\nFeatures: {}' '\n' '\n---' '\n' @@ -248,11 +247,6 @@ def submit_request_to_go_live(service_id): form.start_date.data, form.start_volume.data, form.peak_volume.data, - formatted_list(filter(None, ( - 'one off' if form.method_one_off.data else None, - 'file upload' if form.method_upload.data else None, - 'API' if form.method_api.data else None, - )), before_each='', after_each=''), service_id=current_service.id, organisation=AgreementInfo.from_current_user().owner, service_name=current_service.name, diff --git a/app/templates/views/service-settings/submit-request-to-go-live.html b/app/templates/views/service-settings/submit-request-to-go-live.html index c6a352d11..495f1a0f0 100644 --- a/app/templates/views/service-settings/submit-request-to-go-live.html +++ b/app/templates/views/service-settings/submit-request-to-go-live.html @@ -28,11 +28,6 @@ {{ textbox(form.start_volume, width='1-1', hint='For example, ‘1,000 per month’.') }} {{ textbox(form.peak_volume, width='1-1', hint='For example, ‘Messages will increase to 20,000 per month in January’.') }} - {{ checkbox_group('How are you going to send messages?', [ - form.method_one_off, - form.method_upload, - form.method_api - ]) }}

By requesting to go live you’re agreeing to our terms of use.

diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index 958636869..72f2af6a1 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -698,14 +698,6 @@ def test_should_show_request_to_go_live( assert normalize_spaces( page.select_one('label[for=channel_{}]'.format(channel)).text ) == label - for feature, label in ( - ('one_off', 'One at a time'), - ('upload', 'Upload a spreadsheet of recipients'), - ('api', 'Integrate with the GOV.UK Notify API'), - ): - assert normalize_spaces( - page.select_one('label[for=method_{}]'.format(feature)).text - ) == label @freeze_time("2012-12-21") @@ -729,9 +721,6 @@ def test_should_redirect_after_request_to_go_live( 'start_date': '01/01/2017', 'start_volume': '100,000', 'peak_volume': '2,000,000', - 'method_one_off': 'y', - 'method_upload': 'y', - 'method_api': 'y', }, _follow_redirects=True ) @@ -753,7 +742,6 @@ def test_should_redirect_after_request_to_go_live( 'Start date: 01/01/2017\n' 'Start volume: 100,000\n' 'Peak volume: 2,000,000\n' - 'Features: one off, file upload and API\n' '\n' '---\n' '{}\tNone\tservice one\tTest User\ttest@user.gov.uk\t-\t21/12/2012'