darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 13:39:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve the performance of /platform-admin

Browse Source 
Using a new endpoint in API to get the aggregate platform admin stats.

Relies on https://github.com/alphagov/notifications-api/pull/1332
This commit is contained in:
Rebecca Law
2017-10-23 15:08:08 +01:00
parent 65d02bb9ba
commit 7f8e935b44
4 changed files with 136 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
app/main/views/platform_admin.py
View File

@@ -28,13 +28,16 @@ def platform_admin():
api_args['start_date'] = form.start_date.data
api_args['end_date'] = form.end_date.data or datetime.utcnow().date()
services = service_api_client.get_services(api_args)['data']
platform_stats = service_api_client.get_aggregate_platform_stats(api_args)
for stat in platform_stats.values():
stat['failure_rate'] = get_formatted_percentage(stat['failed'], stat['requested'])
return render_template(
'views/platform-admin/index.html',
include_from_test_key=form.include_from_test_key.data,
form=form,
global_stats=create_global_stats(services),
global_stats=platform_stats,
)
@@ -120,6 +123,36 @@ def create_global_stats(services):
return stats
def platform_failure_percentages(services):
stats = {
'email': {
'delivered': 0,
'failed': 0,
'requested': 0
},
'sms': {
'delivered': 0,
'failed': 0,
'requested': 0
},
'letter': {
'delivered': 0,
'failed': 0,
'requested': 0
}
}
for service in services:
for msg_type, status in itertools.product(('sms', 'email', 'letter'), ('delivered', 'failed', 'requested')):
import pdb
pdb.set_trace()
stats[msg_type][status] += service[msg_type][status]
for stat in stats.values():
stat['failure_rate'] = get_formatted_percentage(stat['failed'], stat['requested'])
return stats
def format_stats_by_service(services):
for service in services:
yield {