darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-26 17:24:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Missed a unit test update

Browse Source
This commit is contained in:
Alex Janousek
2025-09-26 14:36:50 -04:00
parent 2ba2ba6f86
commit 7f270879d6
1 changed files with 14 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
tests/app/main/views/test_job_notification_updates.py
View File

@@ -46,25 +46,14 @@ def test_poll_status_notification_update_logic(
job is finished (regardless of count) job is finished (regardless of count)
""" """
total = delivered + failed + pending total = delivered + failed + pending
job_status = "finished" if finished else "sending"
mock_job = mocker.patch("app.job_api_client.get_job") mock_job_status = mocker.patch("app.job_api_client.get_job_status")
mock_job.return_value = { mock_job_status.return_value = {
"data": { "sent_count": delivered,
**job_json( "failed_count": failed,
service_one["id"], "pending_count": pending,
created_by=user_json(), "total_count": total,
job_id=fake_uuid, "processing_finished": finished,
job_status=job_status,
notification_count=total,
notifications_requested=total,
),
"statistics": [
{"status": "delivered", "count": delivered},
{"status": "failed", "count": failed},
{"status": "pending", "count": pending},
],
}
} }
response = client_request.get_response( response = client_request.get_response(
@@ -107,23 +96,13 @@ def test_poll_status_provides_required_fields(
fake_uuid, fake_uuid,
): ):
"""Verify poll status endpoint returns all fields needed for notification update logic.""" """Verify poll status endpoint returns all fields needed for notification update logic."""
mock_job = mocker.patch("app.job_api_client.get_job") mock_job_status = mocker.patch("app.job_api_client.get_job_status")
mock_job.return_value = { mock_job_status.return_value = {
"data": { "sent_count": 15,
**job_json( "failed_count": 5,
service_one["id"], "pending_count": 5,
created_by=user_json(), "total_count": 25,
job_id=fake_uuid, "processing_finished": False,
job_status="sending",
notification_count=25,
notifications_requested=25,
),
"statistics": [
{"status": "delivered", "count": 15},
{"status": "failed", "count": 5},
{"status": "pending", "count": 5},
],
}
} }
response = client_request.get_response( response = client_request.get_response(