darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

don't allow us to create permissions decorator without permissions

Browse Source 
ie: not for an organisation, and not for a service
This commit is contained in:
Leo Hemsted
2018-03-01 12:08:22 +00:00
parent d14f33ea70
commit 7f268c0ab3
3 changed files with 46 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/notify_client/models.py
View File

@@ -121,20 +121,23 @@ class User(UserMixin):
if unknown_permissions:
raise TypeError('{} are not valid permissions'.format(list(unknown_permissions)))
# platform admins should be able to do most things (except eg send messages, or create api keys)
if self.platform_admin and not restrict_admin_usage:
return True
# Service id is always set on the request for service specific views.
service_id = _get_service_id_from_view_args()
org_id = _get_org_id_from_view_args()
if not service_id and not org_id:
# we shouldn't have any pages that require permissions, but don't specify a service or organisation.
# use @user_is_platform_admin for platform admin only pages
raise NotImplementedError
# platform admins should be able to do most things (except eg send messages, or create api keys)
if self.platform_admin and not restrict_admin_usage:
return True
if org_id:
return org_id in self.organisations
elif service_id:
return any(x in self._permissions.get(service_id, []) for x in permissions)
else:
return False
def has_permission_for_service(self, service_id, permission):
return permission in self._permissions.get(service_id, [])