Merge pull request #2136 from alphagov/guess-name

Guess people’s names when they’re invited

app/assets/stylesheets/app.scss

@@ -257,3 +257,7 @@ details .arrow {
   outline: 2px solid $black;
   max-width: 100%;
 }
+
+.nowrap {
+  white-space: nowrap;
+}

app/main/forms.py

@@ -41,6 +41,7 @@ from app.main.validators import (
     ValidGovEmail,
 )
 from app.notify_client.models import roles
+from app.utils import guess_name_from_email_address
 
 
 def get_time_value_and_label(future_time):
@@ -215,20 +216,18 @@ class RegisterUserForm(StripWhitespaceForm):
     auth_type = HiddenField('auth_type', default='sms_auth')
 
 
-class RegisterUserFromInviteForm(StripWhitespaceForm):
+class RegisterUserFromInviteForm(RegisterUserForm):
     def __init__(self, invited_user):
         super().__init__(
             service=invited_user['service'],
             email_address=invited_user['email_address'],
             auth_type=invited_user['auth_type'],
+            name=guess_name_from_email_address(
+                invited_user['email_address']
+            ),
         )
 
-    name = StringField(
-        'Full name',
-        validators=[DataRequired(message='Can’t be empty')]
-    )
     mobile_number = InternationalPhoneNumber('Mobile number', validators=[])
-    password = password()
     service = HiddenField('service')
     email_address = HiddenField('email_address')
     auth_type = HiddenField('auth_type', validators=[DataRequired()])

app/templates/views/register-from-invite.html

@@ -11,7 +11,10 @@ Create an account
 <div class="grid-row">
   <div class="column-two-thirds">
     <h1 class="heading-large">Create an account</h1>
-    <p>Your account will be created with this email: {{invited_user.email_address}}</p>
+    <p>
+      Your account will be created with this email address:
+      <span class="nowrap">{{invited_user.email_address}}</span>
+    </p>
     <form method="post" autocomplete="off">
       {{ textbox(form.name, width='3-4') }}
       {% if invited_user.auth_type == 'sms_auth' %}

app/utils.py

@@ -25,7 +25,9 @@ from flask import (
     url_for,
 )
 from flask_login import current_user
+from notifications_utils.formatters import make_quotes_smart
 from notifications_utils.recipients import RecipientCSV
+from notifications_utils.take import Take
 from notifications_utils.template import (
     EmailPreviewTemplate,
     LetterImageTemplate,
@@ -613,3 +615,43 @@ class GovernmentEmailDomain(AgreementInfo):
 def unicode_truncate(s, length):
     encoded = s.encode('utf-8')[:length]
     return encoded.decode('utf-8', 'ignore')
+
+
+def starts_with_initial(name):
+    return bool(re.match(r'^.\.', name))
+
+
+def remove_middle_initial(name):
+    return re.sub(r'\s+.\s+', ' ', name)
+
+
+def remove_digits(name):
+    return ''.join(c for c in name if not c.isdigit())
+
+
+def normalize_spaces(name):
+    return ' '.join(name.split())
+
+
+def guess_name_from_email_address(email_address):
+
+    possible_name = re.split(r'[\@\+]', email_address)[0]
+
+    if '.' not in possible_name or starts_with_initial(possible_name):
+        return ''
+
+    return Take(
+        possible_name
+    ).then(
+        str.replace, '.', ' '
+    ).then(
+        remove_digits
+    ).then(
+        remove_middle_initial
+    ).then(
+        str.title
+    ).then(
+        make_quotes_smart
+    ).then(
+        normalize_spaces
+    )