darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 10:03:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix HTML showing up on breaking change page

Browse Source 
The breaking change page temporarily holds the changes in hidden inputs
on the page. The messages content it gets from the `.content` property
on the subject. This is raw and not transformed in any way, so fine.

For the subject it gets the value from the `.subject` attribute on the
template. For email templates, this will be transformed to highlight
placeholders with `<span class='placeholder'>…`. This means that when
the change is confirmed, it’s this encoded version that gets sent to the
API. Which is bad, because we then save `<span class='placeholder'>` in
the database.

This commit changes the page to look at the `._subject` attribute
instead, which is the internal, untransformed version of the subject.
This commit is contained in:
Chris Hill-Scott
2017-03-07 15:11:37 +00:00
parent c51c954efc
commit 7e185f67b1
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/templates/breaking-change.html
View File

@@ -27,7 +27,7 @@
<form method="post">
<input type="hidden" name="name" value="{{ new_template.name }}" />
<input type="hidden" name="subject" value="{{ new_template.subject or '' }}" />
<input type="hidden" name="subject" value="{{ new_template._subject or '' }}" />
<input type="hidden" name="template_content" value="{{ new_template.content }}" />
<input type="hidden" name="template_id" value="{{ new_template.id }}" />