From 6ccd0e6775ed602d3682fa6ad7dabb04736288b2 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Thu, 30 Aug 2018 16:56:09 +0100 Subject: [PATCH 1/8] Added send a document by email guidance Added send a document by email guidance --- .../partials/templates/guidance-send-a-document | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 app/templates/partials/templates/guidance-send-a-document diff --git a/app/templates/partials/templates/guidance-send-a-document b/app/templates/partials/templates/guidance-send-a-document new file mode 100644 index 000000000..cbda8ad42 --- /dev/null +++ b/app/templates/partials/templates/guidance-send-a-document @@ -0,0 +1,14 @@ +

+ Send a document by email +

+

+ Use double brackets to add a placeholder field to your template. This will contain a secure link to download the document. +

+
+

+ Download your document at: ((link_to_document)) +

+
+

+ Next, upload your document. Follow the instructions to send a document by email in the API client documentation. +

From 7ce12c88c954ce4003e01373131a416806ef656d Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 3 Sep 2018 13:37:02 +0100 Subject: [PATCH 2/8] Commented out the link to documentation Commented out the link to documentation because sending a document is only described in the Python documentation at the moment. Discussed with Chris H: Added a line asking users to contact the team. Support can explain the situation if we get any requests. We'll remove this and reinstate the original line once this feature is available across more API clients and the documentation is updated. --- app/templates/partials/templates/guidance-send-a-document | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/templates/partials/templates/guidance-send-a-document b/app/templates/partials/templates/guidance-send-a-document index cbda8ad42..2706403f1 100644 --- a/app/templates/partials/templates/guidance-send-a-document +++ b/app/templates/partials/templates/guidance-send-a-document @@ -9,6 +9,10 @@ Download your document at: ((link_to_document))

+ +

+ Contact the GOV.UK Notify team to enable this function for your service. From 3bbb944786f9bd691f9132ce7628d83631b9ad86 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 3 Sep 2018 15:03:44 +0100 Subject: [PATCH 3/8] Added send a document guidance to the template Added send a document guidance to the template --- app/templates/views/edit-email-template.html | 1 + 1 file changed, 1 insertion(+) diff --git a/app/templates/views/edit-email-template.html b/app/templates/views/edit-email-template.html index bc6010a29..669b19a22 100644 --- a/app/templates/views/edit-email-template.html +++ b/app/templates/views/edit-email-template.html @@ -31,6 +31,7 @@ {% include "partials/templates/guidance-personalisation.html" %} {% include "partials/templates/guidance-optional-content.html" %} {% include "partials/templates/guidance-links.html" %} + {% include "partials/templates/guidance-send-a-document.html" %} From 80070797f410d1cbc85e48f972c3e3ac113a8a09 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 3 Sep 2018 15:05:19 +0100 Subject: [PATCH 4/8] Added filename extension Added filename extension --- .../{guidance-send-a-document => guidance-send-a-document.html} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename app/templates/partials/templates/{guidance-send-a-document => guidance-send-a-document.html} (100%) diff --git a/app/templates/partials/templates/guidance-send-a-document b/app/templates/partials/templates/guidance-send-a-document.html similarity index 100% rename from app/templates/partials/templates/guidance-send-a-document rename to app/templates/partials/templates/guidance-send-a-document.html From 891ae95d2b2020135c464fc26af839c1405e3760 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 3 Sep 2018 16:21:42 +0100 Subject: [PATCH 5/8] Restrict DD guidance to teams who can use it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Document download is in private beta, which means most teams using Notify can’t see or use it. We shouldn’t confuse people by showing them this guidance, especially while it’s API-only. --- app/templates/views/edit-email-template.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/templates/views/edit-email-template.html b/app/templates/views/edit-email-template.html index 669b19a22..1a3a40bc9 100644 --- a/app/templates/views/edit-email-template.html +++ b/app/templates/views/edit-email-template.html @@ -31,7 +31,9 @@ {% include "partials/templates/guidance-personalisation.html" %} {% include "partials/templates/guidance-optional-content.html" %} {% include "partials/templates/guidance-links.html" %} - {% include "partials/templates/guidance-send-a-document.html" %} + {% if current_service.has_permission('upload_document') %} + {% include "partials/templates/guidance-send-a-document.html" %} + {% endif %} From 3f3f8c5977e2318f9066558072d9932446c2fb8b Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 3 Sep 2018 17:04:21 +0100 Subject: [PATCH 6/8] Reinstated link to API client documentation Reinstated link to API client documentation because we're only showing this guidance to users who already have the send a document feature. --- .../partials/templates/guidance-send-a-document.html | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/templates/partials/templates/guidance-send-a-document.html b/app/templates/partials/templates/guidance-send-a-document.html index 2706403f1..cbda8ad42 100644 --- a/app/templates/partials/templates/guidance-send-a-document.html +++ b/app/templates/partials/templates/guidance-send-a-document.html @@ -9,10 +9,6 @@ Download your document at: ((link_to_document))

- -

- Contact the GOV.UK Notify team to enable this function for your service. From 42417b3509387f325e3c50182614f45f3661792b Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 4 Sep 2018 10:02:54 +0100 Subject: [PATCH 7/8] Removed link to documentation Removed link to documentation until we have Features content we can link to, or the documentation has been updated. --- .../partials/templates/guidance-send-a-document.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/templates/partials/templates/guidance-send-a-document.html b/app/templates/partials/templates/guidance-send-a-document.html index cbda8ad42..c97d0eeef 100644 --- a/app/templates/partials/templates/guidance-send-a-document.html +++ b/app/templates/partials/templates/guidance-send-a-document.html @@ -9,6 +9,6 @@ Download your document at: ((link_to_document))

-

- Next, upload your document. Follow the instructions to send a document by email in the API client documentation. -

+ From 22b6b8f41206eba8d7d2f67284eb1ab51d4742fa Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 10 Sep 2018 14:47:22 +0100 Subject: [PATCH 8/8] Added a reminder to upload the document Added a reminder to upload the document using the API. --- app/templates/partials/templates/guidance-send-a-document.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/templates/partials/templates/guidance-send-a-document.html b/app/templates/partials/templates/guidance-send-a-document.html index c97d0eeef..4d8e50ab8 100644 --- a/app/templates/partials/templates/guidance-send-a-document.html +++ b/app/templates/partials/templates/guidance-send-a-document.html @@ -9,6 +9,5 @@ Download your document at: ((link_to_document))

-