Handle files that can’t be interpreted as spreadsheets

Browse Source

There shouldn’t be a case where we see a `ValueError` on upload any
more. Our file handling should be robust enough to deal with whatever is
thrown at it.

This commit:
- adds test files with bad data (PNG files with their extensions changed to look
  like spreadsheets)
- catches whatever exceptions are raised by trying to parse these files
- returns a helpful flash message to the user

Anything else should raise a `500`, eg if the file can’t be uploaded to S3.

...

This commit is contained in:

Chris Hill-Scott

2016-05-15 22:11:01 +01:00

parent 1409ca36ca

commit 7bbc307a3e

8 changed files with 34 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

tests/non_spreadsheet_files/actually_a_png.xls

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 43 KiB