darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 10:03:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don’t inherit directly from admin template

Browse Source 
Pages that don’t have navigation shouldn’t extend the top-level admin
template directly.

They should extend `withoutnav_template.html` instead, because then they
get a wrapping `<main>` element, which is good semantically and for
accessibility, and also defaults the font size to `19px`.
This commit is contained in:
Chris Hill-Scott
2016-09-28 15:05:54 +01:00
parent 317a01972c
commit 79e0881a23
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/templates/views/user-profile/authenticate.html
View File

@@ -1,4 +1,4 @@
{% extends "admin_template.html" %} {% extends "withoutnav_template.html" %}
{% from "components/textbox.html" import textbox %} {% from "components/textbox.html" import textbox %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
@@ -6,7 +6,7 @@
GOV.UK Notify | Service settings GOV.UK Notify | Service settings
{% endblock %} {% endblock %}
{% block fullwidth_content %} {% block maincolumn_content %}
<h1 class="heading-large">Change your {{ thing }}</h1> <h1 class="heading-large">Change your {{ thing }}</h1>

4
app/templates/views/user-profile/change-password.html
View File

@@ -1,4 +1,4 @@
{% extends "admin_template.html" %} {% extends "withoutnav_template.html" %}
{% from "components/textbox.html" import textbox %} {% from "components/textbox.html" import textbox %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
@@ -6,7 +6,7 @@
GOV.UK Notify | Service settings GOV.UK Notify | Service settings
{% endblock %} {% endblock %}
{% block fullwidth_content %} {% block maincolumn_content %}
<h1 class="heading-large">Change your password</h1> <h1 class="heading-large">Change your password</h1>

4
app/templates/views/user-profile/change.html
View File

@@ -1,4 +1,4 @@
{% extends "admin_template.html" %} {% extends "withoutnav_template.html" %}
{% from "components/textbox.html" import textbox %} {% from "components/textbox.html" import textbox %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
@@ -6,7 +6,7 @@
GOV.UK Notify | Service settings GOV.UK Notify | Service settings
{% endblock %} {% endblock %}
{% block fullwidth_content %} {% block maincolumn_content %}
<h1 class="heading-large">Change your {{ thing }}</h1> <h1 class="heading-large">Change your {{ thing }}</h1>

4
app/templates/views/user-profile/confirm.html
View File

@@ -1,4 +1,4 @@
{% extends "admin_template.html" %} {% extends "withoutnav_template.html" %}
{% from "components/textbox.html" import textbox %} {% from "components/textbox.html" import textbox %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
@@ -6,7 +6,7 @@
GOV.UK Notify | Service settings GOV.UK Notify | Service settings
{% endblock %} {% endblock %}
{% block fullwidth_content %} {% block maincolumn_content %}
<h1 class="heading-large">Change your {{ thing }}</h1> <h1 class="heading-large">Change your {{ thing }}</h1>