darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add .nvmrc & use NVM to manage installed Node version

Browse Source 
We have decided to use NVM to manage installed Node versions locally
and in CI to ensure they match and produce consistent builds.

Running `nvm install` will install the Node version specified in the
`.nvmrc` file.

This is now consistent with Document Download Frontend.
See: alphagov/document-download-frontend#114

Signed-off-by: Richard Baker <richard.baker@digital.cabinet-office.gov.uk>
This commit is contained in:
Richard Baker
2022-04-05 12:00:26 +01:00
parent 5fa324a680
commit 799949a3f4
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile
View File

@@ -25,8 +25,8 @@ VIRTUALENV_ROOT := $(shell [ -z $$VIRTUAL_ENV ] && echo $$(pwd)/venv || echo $$V
.PHONY: bootstrap
bootstrap: generate-version-file ## Set up everything to run the app
pip3 install -r requirements_for_test.txt
npm install
. environment.sh; npm run build
source $(HOME)/.nvm/nvm.sh && nvm install && npm ci
. environment.sh; source $(HOME)/.nvm/nvm.sh && npm run build
.PHONY: watch-frontend
watch-frontend: ## Build frontend and watch for changes
@@ -56,7 +56,7 @@ generate-version-file: ## Generates the app version file
test: ## Run tests
flake8 .
isort --check-only ./app ./tests
npm test
source $(HOME)/.nvm/nvm.sh && npm test
py.test -n auto --maxfail=10 tests/
.PHONY: fix-imports