Allow uploaded letters to be sent if valid

Added a send button which only appears on the page if the query string
indicates that the PDF is valid. Before actually sending, we check that
the service has the right permissions and that the metadata for the
letter confirms the letter is valid (because the query string can be
changed).

tests/app/main/views/test_uploads.py

@@ -50,6 +50,10 @@ def test_post_upload_letter_redirects_for_valid_file(mocker, client_request):
     assert page.find('h1').text == 'tests/test_pdf_files/one_page_pdf.pdf'
     assert not page.find(id='validation-error-message')
 
+    assert page.find('input', {'type': 'hidden', 'name': 'filename', 'value': 'tests/test_pdf_files/one_page_pdf.pdf'})
+    assert page.find('input', {'type': 'hidden', 'name': 'file_id', 'value': 'fake-uuid'})
+    assert page.find('button', {'type': 'submit'}).text == 'Send 1 letter'
+
 
 def test_post_upload_letter_shows_letter_preview_for_valid_file(mocker, client_request):
     letter_template = {'template_type': 'letter',
@@ -182,6 +186,7 @@ def test_post_upload_letter_with_invalid_file(mocker, client_request):
     assert normalize_spaces(
         page.find(id='validation-error-message').text
     ) == 'Validation failed'
+    assert not page.find('button', {'type': 'submit'})
 
 
 def test_post_upload_letter_shows_letter_preview_for_invalid_file(mocker, client_request):
@@ -254,3 +259,66 @@ def test_uploaded_letter_preview(mocker, client_request):
 
     assert page.find('h1').text == 'my_letter.pdf'
     assert page.find('div', class_='letter-sent')
+
+
+def test_send_uploaded_letter_sends_letter_and_redirects_to_notification_page(mocker, service_one, client_request):
+    mocker.patch('app.main.views.uploads.get_letter_pdf_and_metadata', return_value=('file', {'status': 'valid'}))
+    mock_send = mocker.patch('app.main.views.uploads.notification_api_client.send_precompiled_letter')
+
+    service_one['permissions'] = ['letter', 'upload_letters']
+    file_id = 'abcd-1234'
+
+    client_request.post(
+        'main.send_uploaded_letter',
+        service_id=SERVICE_ONE_ID,
+        _data={'filename': 'my_file.pdf', 'file_id': file_id},
+        _expected_redirect=url_for(
+            'main.view_notification',
+            service_id=SERVICE_ONE_ID,
+            notification_id=file_id,
+            _external=True
+        )
+    )
+    mock_send.assert_called_once_with(SERVICE_ONE_ID, 'my_file.pdf', file_id)
+
+
+@pytest.mark.parametrize('permissions', [
+    ['email'],
+    ['letter'],
+    ['upload_letters'],
+])
+def test_send_uploaded_letter_when_service_does_not_have_correct_permissions(
+    mocker,
+    service_one,
+    client_request,
+    permissions,
+):
+    mocker.patch('app.main.views.uploads.get_letter_pdf_and_metadata', return_value=('file', {'status': 'valid'}))
+    mock_send = mocker.patch('app.main.views.uploads.notification_api_client.send_precompiled_letter')
+
+    service_one['permissions'] = permissions
+    file_id = 'abcd-1234'
+
+    client_request.post(
+        'main.send_uploaded_letter',
+        service_id=SERVICE_ONE_ID,
+        _data={'filename': 'my_file.pdf', 'file_id': file_id},
+        _expected_status=403
+    )
+    assert not mock_send.called
+
+
+def test_send_uploaded_letter_when_metadata_states_pdf_is_invalid(mocker, service_one, client_request):
+    mocker.patch('app.main.views.uploads.get_letter_pdf_and_metadata', return_value=('file', {'status': 'invalid'}))
+    mock_send = mocker.patch('app.main.views.uploads.notification_api_client.send_precompiled_letter')
+
+    service_one['permissions'] = ['letter', 'upload_letters']
+    file_id = 'abcd-1234'
+
+    client_request.post(
+        'main.send_uploaded_letter',
+        service_id=SERVICE_ONE_ID,
+        _data={'filename': 'my_file.pdf', 'file_id': file_id},
+        _expected_status=403
+    )
+    assert not mock_send.called

tests/app/notify_client/test_notification_client.py

@@ -59,6 +59,23 @@ def test_send_notification(mocker, logged_in_client, active_user_with_permission
     )
 
 
+def test_send_precompiled_letter(mocker, logged_in_client, active_user_with_permissions):
+    mock_post = mocker.patch('app.notify_client.notification_api_client.NotificationApiClient.post')
+    NotificationApiClient().send_precompiled_letter(
+        'abcd-1234',
+        'my_file.pdf',
+        'file-ID'
+    )
+    mock_post.assert_called_once_with(
+        url='/service/abcd-1234/send-pdf-letter',
+        data={
+            'filename': 'my_file.pdf',
+            'file_id': 'file-ID',
+            'created_by': active_user_with_permissions['id']
+        }
+    )
+
+
 def test_get_notification(mocker):
     mock_get = mocker.patch('app.notify_client.notification_api_client.NotificationApiClient.get')
     NotificationApiClient().get_notification('foo', 'bar')