Let users without send_messages view broadcasts

At the moment viewing a broadcast is limited to those users who have
the `send_messages` permission.

This doesn’t match how we describe the permissions on the team members
page

This commit makes it so that any team member can see a broadcast that’s
in any state other than `draft`.
This commit is contained in:
Chris Hill-Scott
2020-08-10 12:13:11 +01:00
parent 38953d1c28
commit 78c88530b5
3 changed files with 54 additions and 3 deletions

View File

@@ -182,7 +182,7 @@ def preview_broadcast_message(service_id, broadcast_message_id):
@main.route('/services/<uuid:service_id>/broadcast/<uuid:broadcast_message_id>')
@user_has_permissions('send_messages')
@user_has_permissions()
@service_has_permission('broadcast')
def view_broadcast_message(service_id, broadcast_message_id):
broadcast_message = BroadcastMessage.from_id(

View File

@@ -18,7 +18,7 @@
) }}
{% if broadcast_message.status == 'pending-approval' %}
{% if broadcast_message.created_by == current_user %}
{% if broadcast_message.created_by == current_user and current_user.has_permissions('send_messages') %}
<div class="banner govuk-!-margin-bottom-6">
<h2 class="govuk-heading-s govuk-!-margin-bottom-3">Your broadcast is waiting for approval from another member of your team</h2>
<p class="govuk-body">Once approved it will be live until
@@ -29,7 +29,7 @@
delete_link_text='Withdraw this broadcast'
) }}
</div>
{% else %}
{% elif current_user.has_permissions('send_messages') %}
{% call form_wrapper(class="banner govuk-!-margin-bottom-6") %}
<p class="govuk-body govuk-!-margin-top-0 govuk-!-margin-bottom-3">
{{ broadcast_message.created_by.name }} wants to broadcast this
@@ -41,6 +41,13 @@
delete_link_text='Reject this broadcast'
) }}
{% endcall %}
{% else %}
<div class="banner govuk-!-margin-bottom-6">
<h2 class="govuk-heading-s govuk-!-margin-bottom-3">This broadcast is waiting for approval</h2>
<p class="govuk-body">
You dont have permission to approve broadcasts.
</p>
</div>
{% endif %}
{% else %}
<p class="govuk-body govuk-!-margin-bottom-3">