darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 05:59:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use folder_permissions in the InvitedUser model

Browse Source 
We were already invitializing InvitedUser with folder_permissions
(defaulting to None), but this removes the default and adds
folder_permissions to the serialize method. Folder permissions should
now always be returned from api, either as an empty list or a list of
UUIDs.
This commit is contained in:
Katie Smith
2019-03-15 10:25:00 +00:00
parent 15b74a74fb
commit 782bd34394
5 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/views/test_register.py
View File

@@ -198,7 +198,7 @@ def test_shows_registration_page_from_invite(
["manage_users"],
"pending",
datetime.utcnow(),
'sms_auth',
'sms_auth', []
).serialize()
page = client_request.get('main.register_from_invite')
assert page.select_one('input[name=name]')['value'] == expected_value
@@ -217,7 +217,8 @@ def test_register_from_invite(
["manage_users"],
"pending",
datetime.utcnow(),
'sms_auth')
'sms_auth',
[])
with client.session_transaction() as session:
session['invited_user'] = invited_user.serialize()
response = client.post(
@@ -253,7 +254,8 @@ def test_register_from_invite_when_user_registers_in_another_browser(
["manage_users"],
"pending",
datetime.utcnow(),
'sms_auth')
'sms_auth',
[])
with client.session_transaction() as session:
session['invited_user'] = invited_user.serialize()
response = client.post(

5
tests/app/notify_client/test_invite_client.py
View File

@@ -16,12 +16,12 @@ def test_client_creates_invite(
'app.invite_api_client.post',
return_value={'data': dict.fromkeys({
'id', 'service', 'from_user', 'email_address',
'permissions', 'status', 'created_at', 'auth_type'
'permissions', 'status', 'created_at', 'auth_type', 'folder_permissions'
})}
)
invite_api_client.create_invite(
'12345', '67890', 'test@example.com', {'send_messages'}, 'sms_auth'
'12345', '67890', 'test@example.com', {'send_messages'}, 'sms_auth', [fake_uuid]
)
mock_post.assert_called_once_with(
@@ -34,6 +34,7 @@ def test_client_creates_invite(
'created_by': ANY,
'permissions': 'send_emails,send_letters,send_texts',
'invite_link_host': 'http://localhost:6012',
'folder_permissions': [fake_uuid]
}
)