darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-28 19:59:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop passing in today_only for the get_service_statistics method.

Browse Source 
We now only ever call it with False.
To remove it from the api call will require a change in the API so will do that at another time.
This commit is contained in:
Rebecca Law
2021-06-28 10:11:22 +01:00
parent 44f02f2e30
commit 77c2aa9fd6
4 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/views/jobs.py
View File

@@ -272,7 +272,6 @@ def get_notifications(service_id, message_type, status_override=None):
message_type,
service_api_client.get_service_statistics(
service_id,
today_only=False,
limit_days=service_data_retention_days
)
)

6
app/notify_client/service_api_client.py
View File

@@ -43,10 +43,8 @@ class ServiceAPIClient(NotifyAdminAPIClient):
"""
return self.get('/service/{0}'.format(service_id))
def get_service_statistics(self, service_id, today_only, limit_days=None):
return self.get('/service/{0}/statistics'.format(service_id), params={
'today_only': today_only, 'limit_days': limit_days
})['data']
def get_service_statistics(self, service_id, limit_days=None):
return self.get('/service/{0}/statistics'.format(service_id), params={'limit_days': limit_days})['data']
def get_services(self, params_dict=None):
"""