darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues from pull request review

Browse Source 
Fixes for the following:
- `<p>` tags need `govuk-body` class
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375921631
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375924387
- unused JS file
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375949386
- link to GDS has incorrect href
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375966464
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375966555
This commit is contained in:
Tom Byers
2020-02-07 11:15:18 +00:00
parent fbff4beef5
commit 76240d5d55
3 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/error_pages/5xx.html
View File

@@ -71,10 +71,10 @@
<h1 class="govuk-heading-l govuk-!-padding-top-7">
Sorry, there is a problem with the service
</h1>
<p>
<p class="govuk-body">
Try again later.
</p>
<p>
<p class="govuk-body">
You can check our <a href="https://status.notifications.service.gov.uk/">system status</a> page to see if there are any known issues.<br/>To report a problem, email <a href="mailto:notify-support@digital.cabinet-office.gov.uk">notify-support@digital.cabinet-office.gov.uk</a>
</div>
</div>
@@ -88,7 +88,7 @@
<h2 class="govuk-visually-hidden">Support links</h2>
<div class="govuk-footer__meta-custom">
Built by the <a href="#" class="govuk-footer__link">Government Digital Service</a>
Built by the <a href="https://www.gov.uk/government/organisations/government-digital-service" class="govuk-footer__link">Government Digital Service</a>
</div>
<svg