From 74e7590fbce6dbd39d82e03003309ae6cdc945b6 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Tue, 5 Sep 2017 16:18:29 +0100 Subject: [PATCH] If a service does not have an inbound number and they click `change` on Receive text messages, they should see a message saying contact the Notify team to enable this feature. That will now happen again. --- app/main/views/service_settings.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/main/views/service_settings.py b/app/main/views/service_settings.py index 9bd587a93..da2cb1229 100644 --- a/app/main/views/service_settings.py +++ b/app/main/views/service_settings.py @@ -66,10 +66,7 @@ def service_settings(service_id): inbound_api_url = '' inbound_number = inbound_number_client.get_inbound_sms_number_for_service(service_id) - if inbound_number['data'] == {}: - disp_inbound_number = '' - else: - disp_inbound_number = inbound_number['data']['number'] + disp_inbound_number = inbound_number['data'].get('number', '') return render_template( 'views/service-settings.html', @@ -392,9 +389,10 @@ def service_set_international_sms(service_id): @login_required @user_has_permissions('manage_settings', admin_override=True) def service_set_inbound_sms(service_id): + number = inbound_number_client.get_inbound_sms_number_for_service(service_id)['data'].get('number', '') return render_template( 'views/service-settings/set-inbound-sms.html', - inbound_number=inbound_number_client.get_inbound_sms_number_for_service(service_id)['data']['number'], + inbound_number=number, )