darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 01:55:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor event handler code

Browse Source
This commit is contained in:
Katie Smith
2019-05-22 13:15:31 +01:00
parent 00bb7a0ea0
commit 73b4aa4d85
1 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/event_handlers.py
View File

@@ -4,12 +4,12 @@ from app import events_api_client
def on_user_logged_in(_sender, user): def on_user_logged_in(_sender, user):
_send_event(event_type='sucessful_login', user_id=user.id) _send_event('sucessful_login', user_id=user.id)
def create_email_change_event(user_id, updated_by_id, original_email_address, new_email_address): def create_email_change_event(user_id, updated_by_id, original_email_address, new_email_address):
_send_event( _send_event(
event_type='update_user_email', 'update_user_email',
user_id=user_id, user_id=user_id,
updated_by_id=updated_by_id, updated_by_id=updated_by_id,
original_email_address=original_email_address, original_email_address=original_email_address,
@@ -18,30 +18,18 @@ def create_email_change_event(user_id, updated_by_id, original_email_address, ne
def create_mobile_number_change_event(user_id, updated_by_id, original_mobile_number, new_mobile_number): def create_mobile_number_change_event(user_id, updated_by_id, original_mobile_number, new_mobile_number):
_send_event( _send_event(
event_type='update_user_mobile_number', 'update_user_mobile_number',
user_id=user_id, user_id=user_id,
updated_by_id=updated_by_id, updated_by_id=updated_by_id,
original_mobile_number=original_mobile_number, original_mobile_number=original_mobile_number,
new_mobile_number=new_mobile_number) new_mobile_number=new_mobile_number)
def _send_event(**kwargs): def _send_event(event_type, **kwargs):
if not kwargs.get('event_type'):
return
event_data = _construct_event_data(request) event_data = _construct_event_data(request)
event_fields = ('user_id', event_data.update(kwargs)
'updated_by_id',
'original_email_address',
'new_email_address',
'original_mobile_number',
'new_mobile_number')
for field in event_fields: events_api_client.create_event(event_type, event_data)
if kwargs.get(field):
event_data[field] = kwargs[field]
events_api_client.create_event(kwargs['event_type'], event_data)
def _construct_event_data(request): def _construct_event_data(request):