darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 20:18:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make expected behaviour clear in else case

Browse Source 
It feels a bit slippery having an `if`/`elif` with no else; I think that
adding this comment makes the code clearer.
This commit is contained in:
Chris Hill-Scott
2018-06-18 12:52:12 +01:00
committed by Leo Hemsted
parent c2dbc1934f
commit 7397e808a8
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/main/views/api_keys.py
View File

@@ -232,6 +232,12 @@ def delivery_status_callback(service_id):
bearer_token=form.bearer_token.data, bearer_token=form.bearer_token.data,
user_id=current_user.id user_id=current_user.id
) )
else:
# If no callback is set up and the user chooses to continue
# having no callback (ie both fields empty) then there’s
# nothing for us to do here
pass
return redirect(url_for(back_link, service_id=service_id)) return redirect(url_for(back_link, service_id=service_id))
return render_template( return render_template(