code review feedback

tests/app/main/views/test_dashboard.py

@@ -657,9 +657,8 @@ def test_should_show_recent_templates_on_dashboard(
     ]
     assert "Total messages" in headers
 
-    table_rows = page.find_all("tbody")[0].find_all("tr")
-
-    assert len(table_rows) == 0
+    table_rows = page.find_all("tbody")[1].find_all("tr")
+    assert len(table_rows) == 2
 
 
 @pytest.mark.parametrize(
@@ -1943,7 +1942,6 @@ def test_service_dashboard_shows_batched_jobs(
     job_table_body = page.find("table", class_="job-table")
 
     rows = job_table_body.find_all("tbody")[0].find_all("tr")
-
-    assert len(rows) == 0
+    assert len(rows) == 1
 
     assert job_table_body is not None

tests/app/main/views/test_index.py

@@ -94,7 +94,7 @@ def test_hiding_pages_from_search_engines(
         "message_status",
         "how_to_pay",
         "get_started",
-        "guidance_index",
+        "how_to",
         "create_and_send_messages",
         "edit_and_format_messages",
         "send_files_by_email",

tests/app/main/views/test_send.py

@@ -1521,7 +1521,7 @@ def test_link_to_upload_not_offered_when_entering_personalisation(
 
     # We’re entering personalization
     assert page.select_one("input[type=text]")["name"] == "placeholder_value"
-    assert page.select_one("label[for=phone-number]").text.strip() == "name"
+    assert page.select_one("label[for=placeholder_value]").text.strip() == "name"
     # No ‘Upload’ link shown
     assert len(page.select("main a")) == 0
     assert "Upload" not in page.select_one("main").text

tests/app/main/views/test_tour.py

@@ -174,7 +174,10 @@ def test_should_show_empty_text_box(
     # data-module=autofocus is set on a containing element so it
     # shouldn’t also be set on the textbox itself
     assert "data-module" not in textbox
-    assert normalize_spaces(page.select_one("label[for=phone-number]").text) == "one"
+
+    assert (
+        normalize_spaces(page.select_one("label[for=placeholder_value]").text) == "one"
+    )
 
 
 def test_should_prefill_answers_for_get_tour_step(