darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 08:19:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove example personalisation from template page

Browse Source 
This was of dubious value, and the syntax probably isn’t accurate for
all languages.
This commit is contained in:
Chris Hill-Scott
2016-08-10 10:09:04 +01:00
parent 44a0845882
commit 7010e35256
3 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/main/views/send.py
View File

@@ -193,13 +193,9 @@ def send_from_api(service_id, template_id):
service_api_client.get_service_template(service_id, template_id)['data'], service_api_client.get_service_template(service_id, template_id)['data'],
prefix=current_service['name'] prefix=current_service['name']
) )
personalisation = {
placeholder: "..." for placeholder in template.placeholders
}
return render_template( return render_template(
'views/send-from-api.html', 'views/send-from-api.html',
template=template, template=template
personalisation=json.dumps(personalisation, indent=4) if personalisation else None
) )

5
app/templates/views/send-from-api.html
View File

@@ -32,9 +32,4 @@
{{ api_key(template.id, name="Template ID", thing='template ID') }} {{ api_key(template.id, name="Template ID", thing='template ID') }}
</div> </div>
{% if personalisation %}
<h2 class="heading-small">Personalisation (all fields are required)</h2>
{{ personalisation|syntax_highlight_json }}
{% endif %}
{% endblock %} {% endblock %}

2
tests/app/main/views/test_send.py
View File

@@ -251,7 +251,7 @@ def test_api_info_page(
follow_redirects=True follow_redirects=True
) )
assert response.status_code == 200 assert response.status_code == 200
assert 'API integration' in response.get_data(as_text=True) assert 'API info' in response.get_data(as_text=True)
def test_download_example_csv( def test_download_example_csv(