mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-09 02:44:10 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -68,7 +68,7 @@ describe('Update content', () => {
|
||||
|
||||
test("It should add attributes to the elements", () => {
|
||||
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
expect(
|
||||
document.querySelectorAll('[data-module=update-status]')[0].id
|
||||
@@ -88,7 +88,7 @@ describe('Update content', () => {
|
||||
|
||||
document.getElementById('template_content').removeAttribute('aria-describedby');
|
||||
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
expect(
|
||||
document.getElementById('template_content').getAttribute('aria-describedby')
|
||||
@@ -100,7 +100,7 @@ describe('Update content', () => {
|
||||
|
||||
test("It should make requests to the URL specified in the data-updates-url attribute", () => {
|
||||
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
expect($.ajax.mock.calls[0][0]).toEqual(updatesURL);
|
||||
expect($.ajax.mock.calls[0]).toEqual([
|
||||
@@ -123,7 +123,7 @@ describe('Update content', () => {
|
||||
"Initial content"
|
||||
);
|
||||
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
expect(
|
||||
document.querySelectorAll('[data-module=update-status]')[0].textContent.trim()
|
||||
@@ -138,7 +138,7 @@ describe('Update content', () => {
|
||||
let textarea = document.getElementById('template_content');
|
||||
|
||||
// Initial update triggered
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
expect($.ajax.mock.calls.length).toEqual(1);
|
||||
|
||||
// 150ms of inactivity
|
||||
@@ -154,7 +154,7 @@ describe('Update content', () => {
|
||||
let textarea = document.getElementById('template_content');
|
||||
|
||||
// Initial update triggered
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
expect($.ajax.mock.calls.length).toEqual(1);
|
||||
|
||||
helpers.triggerEvent(textarea, 'input');
|
||||
|
||||
Reference in New Issue
Block a user