mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-10 03:14:58 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -64,8 +64,8 @@ describe('Live search', () => {
|
||||
<span class="live-search-relevant">${user.label} (${user.email})</span> (invited)
|
||||
</span>
|
||||
</h3>
|
||||
<ul class="tick-cross-list govuk-grid-row">
|
||||
<div class="tick-cross-list-permissions govuk-grid-column-three-quarters">
|
||||
<ul class="tick-cross-list grid-row">
|
||||
<div class="tick-cross-list-permissions grid-col-9">
|
||||
${getPermissionsHTML(user.permissions)}
|
||||
<div class="tick-cross-list-hint">
|
||||
Can see 15 folders
|
||||
@@ -132,7 +132,7 @@ describe('Live search', () => {
|
||||
test("If there is no search term, the results should be unchanged", () => {
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
const listItems = list.querySelectorAll('.user-list-item');
|
||||
const listItemsShowing = Array.from(listItems).filter(item => !item.classList.contains('js-hidden'));
|
||||
@@ -147,7 +147,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = 'admin';
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
const listItems = list.querySelectorAll('.user-list-item');
|
||||
const listItemsShowing = Array.from(listItems).filter(item => !item.classList.contains('js-hidden'));
|
||||
@@ -163,7 +163,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = 'Administrator (admin@nhs.uk)';
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
const listItems = list.querySelectorAll('.user-list-item');
|
||||
const listItemsShowing = Array.from(listItems).filter(item => !item.classList.contains('js-hidden'));
|
||||
@@ -179,7 +179,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = "Add and edit templates";
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
const listItems = list.querySelectorAll('.user-list-item');
|
||||
const listItemsShowing = Array.from(listItems).filter(item => !item.classList.contains('js-hidden'));
|
||||
@@ -200,7 +200,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = 'Admin';
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
// simulate input of new search text
|
||||
searchTextbox.value = '';
|
||||
@@ -218,7 +218,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = 'Admin';
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
// simulate input of new search text
|
||||
searchTextbox.value = 'Administrator';
|
||||
@@ -237,7 +237,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = 'Admin';
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
// simulate input of new search text
|
||||
searchTextbox.value = 'Administrator (admin@nhs.uk)';
|
||||
@@ -256,7 +256,7 @@ describe('Live search', () => {
|
||||
searchTextbox.value = "Admin";
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
// simulate input of new search text
|
||||
searchTextbox.value = 'Add and edit templates';
|
||||
|
||||
Reference in New Issue
Block a user