mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-31 03:34:52 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -121,7 +121,7 @@ describe('FullscreenTable', () => {
|
||||
test("it fixes the number column for each row without changing the semantics", () => {
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
tableFrame = document.querySelector('.fullscreen-scrollable-table');
|
||||
numberColumnFrame = document.querySelector('.fullscreen-fixed-table');
|
||||
@@ -134,10 +134,10 @@ describe('FullscreenTable', () => {
|
||||
|
||||
test("it calls the sticky JS to update any cached dimensions", () => {
|
||||
|
||||
const stickyJSSpy = jest.spyOn(window.GOVUK.stickAtBottomWhenScrolling, 'recalculate');
|
||||
const stickyJSSpy = jest.spyOn(window.NotifyModules.stickAtBottomWhenScrolling, 'recalculate');
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
expect(stickyJSSpy.mock.calls.length).toBe(1);
|
||||
|
||||
@@ -148,7 +148,7 @@ describe('FullscreenTable', () => {
|
||||
test("the scrolling section is focusable and has an accessible name matching the table caption", () => {
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
tableFrame = document.querySelector('.fullscreen-scrollable-table');
|
||||
caption = tableFrame.querySelector('caption');
|
||||
@@ -163,7 +163,7 @@ describe('FullscreenTable', () => {
|
||||
test("the section providing the fixed row headers is not focusable and is hidden from assistive tech'", () => {
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
fixedRowHeaders = document.querySelector('.fullscreen-fixed-table');
|
||||
|
||||
@@ -194,7 +194,7 @@ describe('FullscreenTable', () => {
|
||||
});
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
tableFrame = document.querySelector('.fullscreen-scrollable-table');
|
||||
numberColumnFrame = document.querySelector('.fullscreen-fixed-table');
|
||||
@@ -254,7 +254,7 @@ describe('FullscreenTable', () => {
|
||||
rowNumberColumnCell.setAttribute('style', 'width: 40px');
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
tableFrame = document.querySelector('.fullscreen-scrollable-table');
|
||||
numberColumnFrame = document.querySelector('.fullscreen-fixed-table');
|
||||
@@ -301,7 +301,7 @@ describe('FullscreenTable', () => {
|
||||
beforeEach(() => {
|
||||
|
||||
// start module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
tableFrame = document.querySelector('.fullscreen-scrollable-table');
|
||||
table = tableFrame.querySelector('table');
|
||||
|
||||
Reference in New Issue
Block a user