darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-09 10:54:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Removed all govuk css (#2814)

Browse Source 
* Removed all govuk css

* Updated reference files

* Removing govuk js

* Fixed casing for modules, removed unused page

* Got more reference images

* Updated template page

* Removed govuk padding util

* Updated hint to uswds hint

* More govuk cleanup

* Commiting backstopjs ref files

* Fixed all unit tests that broke due to brittleness around govuk styling

* Added new ref images

* Final removal of govuk

* Officially removed all govuk references

* Updated reference file

* Updated link to button

* UI modernization

* Cleanup

* removed govuk escaping tests since they are no longer needed

* Fix CodeQL security issue in escapeElementName function

- Escape backslashes first before other special characters
- Prevents potential double-escaping vulnerability
- Addresses CodeQL alert about improper string escaping

* Found more govuk removal. Fixed unit tests

* Add missing pipeline check to pre-commit

* updated test

* Updated e2e test

* More update to e2e test

* Fixed another e2e test

* Simple PR comments addressed

* More updates

* Updated backstop ref files

* Refactored folder selection for non-admins

* Updated redundant line

* Updated tests to include correct mocks

* Added more ref files

* Addressing carlos comments

* Addressing Carlo comments, cleanup of window initing

* More cleanup and addressing carlo comments

* Fixing a11 scan

* Fixed a few issues with javascript

* Fixed for pr

* Fixing e2e tests

* Tweaking e2e test

* Added more ref files and cleaned up urls.js

* Fixed bug with creating new template

* Removed brittle test - addressed code ql comment

* e2e race condition fix

* More e2e test fixes

* Updated e2e tests to not wait for text sent

* Updated test to not wait for button click response

* Made tear down more resilent if staging is down

* reverted e2e test to what was working before main merge

* Updated backstopRef images

* Updated gulp to include job-polling differently
This commit is contained in:
Alex Janousek
2025-10-06 09:38:54 -04:00
committed by GitHub
parent a366a10865
commit 6f5750f095
323 changed files with 2731 additions and 2796 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/javascripts/enhancedTextbox.test.js
View File

@@ -63,7 +63,7 @@ describe('Enhanced textbox', () => {
beforeEach(() => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
});
@@ -98,7 +98,7 @@ describe('Enhanced textbox', () => {
beforeEach(() => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
});
@@ -135,7 +135,7 @@ describe('Enhanced textbox', () => {
setDisplayPropertyOfFormGroups('none');
window.GOVUK.modules.start();
window.NotifyModules.start();
setDisplayPropertyOfFormGroups('block');
@@ -163,7 +163,7 @@ describe('Enhanced textbox', () => {
textarea.textContent = "Dear ((title)) ((name))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -180,7 +180,7 @@ describe('Enhanced textbox', () => {
input.value = "Dear ((title)) ((name))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = input.nextElementSibling;
@@ -198,7 +198,7 @@ describe('Enhanced textbox', () => {
textarea.setAttribute('data-highlight-placeholders', 'false')
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -217,7 +217,7 @@ describe('Enhanced textbox', () => {
textarea.textContent = "When you arrive, please go to the ((weekday??main entrance))((weekend??side entrance))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -234,7 +234,7 @@ describe('Enhanced textbox', () => {
input.value = "When you arrive, please go to the ((weekday??main entrance))((weekend??side entrance))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = input.nextElementSibling;
@@ -270,7 +270,7 @@ describe('Enhanced textbox', () => {
`;
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -288,7 +288,7 @@ describe('Enhanced textbox', () => {
test("If a resize changes the textarea's width, the width of the element below should still match", () => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -310,7 +310,7 @@ describe('Enhanced textbox', () => {
textarea.textContent = "Dear ((title)) ((name))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -330,7 +330,7 @@ describe('Enhanced textbox', () => {
input.value = "Hospital appointment for ((name))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = input.nextElementSibling;
@@ -355,7 +355,7 @@ describe('Enhanced textbox', () => {
textarea.textContent = "Dear ((title)) ((name))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -378,7 +378,7 @@ describe('Enhanced textbox', () => {
input.value = "Hospital appointment";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = input.nextElementSibling;
@@ -405,7 +405,7 @@ describe('Enhanced textbox', () => {
Ref: ((reference))`;
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -426,7 +426,7 @@ describe('Enhanced textbox', () => {
input.value = "Hospital appointment for ((name)), ref: ((reference))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = input.nextElementSibling;
@@ -453,7 +453,7 @@ describe('Enhanced textbox', () => {
Your appointment will be on ((date)). When you arrive, please go to the ((weekday??main entrance))((weekend??side entrance)).`;
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = textarea.nextElementSibling;
@@ -482,7 +482,7 @@ describe('Enhanced textbox', () => {
input.value = "Hospital appointment for ((name))((important?? - IMPORTANT))";
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
backgroundEl = input.nextElementSibling;