mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-26 02:49:16 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -45,7 +45,7 @@ describe('copy to clipboard', () => {
|
||||
document.execCommand = jest.fn(() => {});
|
||||
|
||||
// mock sticky JS
|
||||
window.GOVUK.stickAtBottomWhenScrolling = {
|
||||
window.NotifyModules.stickAtBottomWhenScrolling = {
|
||||
recalculate: jest.fn(() => {})
|
||||
}
|
||||
|
||||
@@ -63,7 +63,7 @@ describe('copy to clipboard', () => {
|
||||
component = document.querySelector('[data-module=copy-to-clipboard]');
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
expect(component.querySelector('button')).toBeNull();
|
||||
|
||||
@@ -120,7 +120,7 @@ describe('copy to clipboard', () => {
|
||||
});
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
});
|
||||
|
||||
@@ -139,7 +139,7 @@ describe('copy to clipboard', () => {
|
||||
test("It should tell any sticky JS present the page has changed", () => {
|
||||
|
||||
// recalculate forces the sticky JS to recalculate any stored DOM position/dimensions
|
||||
expect(window.GOVUK.stickAtBottomWhenScrolling.recalculate).toHaveBeenCalled();
|
||||
expect(window.NotifyModules.stickAtBottomWhenScrolling.recalculate).toHaveBeenCalled();
|
||||
|
||||
});
|
||||
|
||||
@@ -154,7 +154,7 @@ describe('copy to clipboard', () => {
|
||||
|
||||
expect(component.querySelector('.copy-to-clipboard__value').textContent).toBe('00000000-0000-0000-0000-000000000000');
|
||||
|
||||
});
|
||||
});
|
||||
|
||||
});
|
||||
|
||||
@@ -169,7 +169,7 @@ describe('copy to clipboard', () => {
|
||||
component = document.querySelector('[data-module=copy-to-clipboard]');
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
});
|
||||
|
||||
@@ -205,7 +205,7 @@ describe('copy to clipboard', () => {
|
||||
component = document.querySelector('[data-module=copy-to-clipboard]');
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
});
|
||||
|
||||
@@ -233,7 +233,7 @@ describe('copy to clipboard', () => {
|
||||
setUpDOM({ 'thing': 'Some Thing', 'name': 'Some Thing' });
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
component = document.querySelector('[data-module=copy-to-clipboard]');
|
||||
keyEl = component.querySelector('.copy-to-clipboard__value');
|
||||
@@ -332,7 +332,7 @@ describe('copy to clipboard', () => {
|
||||
setUpDOM({ 'thing': 'ID', 'name': 'Default' });
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
component = document.querySelector('[data-module=copy-to-clipboard]');
|
||||
|
||||
@@ -375,7 +375,7 @@ describe('copy to clipboard', () => {
|
||||
setUpDOM({ 'thing': 'Some Thing', 'name': 'Some Thing' });
|
||||
|
||||
// start the module
|
||||
window.GOVUK.modules.start();
|
||||
window.NotifyModules.start();
|
||||
|
||||
component = document.querySelector('[data-module=copy-to-clipboard]');
|
||||
|
||||
|
||||
Reference in New Issue
Block a user