darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-17 21:19:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Removed all govuk css (#2814)

Browse Source 
* Removed all govuk css

* Updated reference files

* Removing govuk js

* Fixed casing for modules, removed unused page

* Got more reference images

* Updated template page

* Removed govuk padding util

* Updated hint to uswds hint

* More govuk cleanup

* Commiting backstopjs ref files

* Fixed all unit tests that broke due to brittleness around govuk styling

* Added new ref images

* Final removal of govuk

* Officially removed all govuk references

* Updated reference file

* Updated link to button

* UI modernization

* Cleanup

* removed govuk escaping tests since they are no longer needed

* Fix CodeQL security issue in escapeElementName function

- Escape backslashes first before other special characters
- Prevents potential double-escaping vulnerability
- Addresses CodeQL alert about improper string escaping

* Found more govuk removal. Fixed unit tests

* Add missing pipeline check to pre-commit

* updated test

* Updated e2e test

* More update to e2e test

* Fixed another e2e test

* Simple PR comments addressed

* More updates

* Updated backstop ref files

* Refactored folder selection for non-admins

* Updated redundant line

* Updated tests to include correct mocks

* Added more ref files

* Addressing carlos comments

* Addressing Carlo comments, cleanup of window initing

* More cleanup and addressing carlo comments

* Fixing a11 scan

* Fixed a few issues with javascript

* Fixed for pr

* Fixing e2e tests

* Tweaking e2e test

* Added more ref files and cleaned up urls.js

* Fixed bug with creating new template

* Removed brittle test - addressed code ql comment

* e2e race condition fix

* More e2e test fixes

* Updated e2e tests to not wait for text sent

* Updated test to not wait for button click response

* Made tear down more resilent if staging is down

* reverted e2e test to what was working before main merge

* Updated backstopRef images

* Updated gulp to include job-polling differently
This commit is contained in:
Alex Janousek
2025-10-06 09:38:54 -04:00
committed by GitHub
parent a366a10865
commit 6f5750f095
323 changed files with 2731 additions and 2796 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tests/javascripts/collapsibleCheckboxes.test.js
View File

@@ -75,7 +75,7 @@ describe('Collapsible fieldset', () => {
beforeEach(() => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
});
@@ -172,7 +172,7 @@ describe('Collapsible fieldset', () => {
test('has the right summary text when started with no checkboxes selected', () => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
const summaryText = document.querySelector('.selection-summary__text');
@@ -189,7 +189,7 @@ describe('Collapsible fieldset', () => {
});
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
const summaryText = document.querySelector('.selection-summary__text');
@@ -203,7 +203,7 @@ describe('Collapsible fieldset', () => {
checkboxes.forEach(el => el.setAttribute('checked', ''));
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
const summaryText = document.querySelector('.selection-summary__text');
@@ -216,7 +216,7 @@ describe('Collapsible fieldset', () => {
wrapper.dataset.fieldLabel = 'team member';
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
const summaryText = document.querySelector('.selection-summary__text');
@@ -229,7 +229,7 @@ describe('Collapsible fieldset', () => {
beforeEach(() => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
@@ -266,7 +266,7 @@ describe('Collapsible fieldset', () => {
beforeEach(() => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
// show the checkboxes
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
@@ -308,7 +308,7 @@ describe('Collapsible fieldset', () => {
test("after the fieldset", () => {
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
// show the checkboxes
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
@@ -326,7 +326,7 @@ describe('Collapsible fieldset', () => {
checkboxesContainer.querySelector('.usa-checkbox').appendChild(nestedCheckboxes);
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
// show the checkboxes
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
@@ -342,10 +342,11 @@ describe('Collapsible fieldset', () => {
beforeEach(() => {
// track calls to sticky JS
window.GOVUK.stickAtBottomWhenScrolling.recalculate = jest.fn(() => {});
window.NotifyModules.stickAtBottomWhenScrolling = window.NotifyModules.stickAtBottomWhenScrolling || {};
window.NotifyModules.stickAtBottomWhenScrolling.recalculate = jest.fn(() => {});
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
// show the checkboxes
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
@@ -374,7 +375,7 @@ describe('Collapsible fieldset', () => {
describe("check/uncheck all functionality", () => {
beforeEach(() => {
window.GOVUK.modules.start();
window.NotifyModules.start();
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
});
@@ -464,7 +465,7 @@ describe('Collapsible fieldset', () => {
describe("toggle button visibility on re-expansion", () => {
test("shows toggle button again when fieldset is re-opened", () => {
window.GOVUK.modules.start();
window.NotifyModules.start();
helpers.triggerEvent(formGroup.querySelector('.selection-footer__button'), 'click');
const toggleButton = document.querySelector('.usa-button--small');
@@ -517,7 +518,7 @@ describe('Collapsible fieldset', () => {
checkFirstCheckbox();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();
@@ -537,7 +538,7 @@ describe('Collapsible fieldset', () => {
checkFirstCheckbox();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();
@@ -557,7 +558,7 @@ describe('Collapsible fieldset', () => {
checkFirstCheckbox();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();
@@ -581,7 +582,7 @@ describe('Collapsible fieldset', () => {
checkAllCheckboxes();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();
@@ -601,7 +602,7 @@ describe('Collapsible fieldset', () => {
checkAllCheckboxes();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();
@@ -625,7 +626,7 @@ describe('Collapsible fieldset', () => {
checkAllCheckboxesButTheLast();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();
@@ -644,7 +645,7 @@ describe('Collapsible fieldset', () => {
checkAllCheckboxesButTheLast();
// start module
window.GOVUK.modules.start();
window.NotifyModules.start();
showCheckboxes();