Removed all govuk css (#2814)

* Removed all govuk css

* Updated reference files

* Removing govuk js

* Fixed casing for modules, removed unused page

* Got more reference images

* Updated template page

* Removed govuk padding util

* Updated hint to uswds hint

* More govuk cleanup

* Commiting backstopjs ref files

* Fixed all unit tests that broke due to brittleness around govuk styling

* Added new ref images

* Final removal of govuk

* Officially removed all govuk references

* Updated reference file

* Updated link to button

* UI modernization

* Cleanup

* removed govuk escaping tests since they are no longer needed

* Fix CodeQL security issue in escapeElementName function

- Escape backslashes first before other special characters
- Prevents potential double-escaping vulnerability
- Addresses CodeQL alert about improper string escaping

* Found more govuk removal. Fixed unit tests

* Add missing pipeline check to pre-commit

* updated test

* Updated e2e test

* More update to e2e test

* Fixed another e2e test

* Simple PR comments addressed

* More updates

* Updated backstop ref files

* Refactored folder selection for non-admins

* Updated redundant line

* Updated tests to include correct mocks

* Added more ref files

* Addressing carlos comments

* Addressing Carlo comments, cleanup of window initing

* More cleanup and addressing carlo comments

* Fixing a11 scan

* Fixed a few issues with javascript

* Fixed for pr

* Fixing e2e tests

* Tweaking e2e test

* Added more ref files and cleaned up urls.js

* Fixed bug with creating new template

* Removed brittle test - addressed code ql comment

* e2e race condition fix

* More e2e test fixes

* Updated e2e tests to not wait for text sent

* Updated test to not wait for button click response

* Made tear down more resilent if staging is down

* reverted e2e test to what was working before main merge

* Updated backstopRef images

* Updated gulp to include job-polling differently
This commit is contained in:
Alex Janousek
2025-10-06 09:38:54 -04:00
committed by GitHub
parent a366a10865
commit 6f5750f095
323 changed files with 2731 additions and 2796 deletions

View File

@@ -19,13 +19,9 @@ def test_should_200_for_tour_start(
template_id=fake_uuid,
)
assert normalize_spaces(page.select(".banner-tour .heading-medium")[0].text) == (
"Try sending yourself this example"
)
selected_hint = page.select(".banner-tour .grid-row")[0]
selected_hint_text = normalize_spaces(selected_hint.select(".usa-body")[0].text)
assert "greyed-out-step" not in selected_hint["class"]
assert selected_hint_text == "Every message is sent from a template"
page_content = normalize_spaces(str(page))
assert ("Try sending yourself this example") in page_content
assert "Every message is sent from a template" in page_content
assert normalize_spaces(page.select(".sms-message-recipient")[0].text) == (
"To: 202-867-5303"
@@ -139,13 +135,9 @@ def test_should_200_for_get_tour_step(
)
assert "Example text message" in normalize_spaces(page.select_one("title").text)
assert normalize_spaces(page.select(".banner-tour .heading-medium")[0].text) == (
"Try sending yourself this example"
)
selected_hint = page.select(".banner-tour .grid-row")[1]
selected_hint_text = normalize_spaces(selected_hint.select(".usa-body")[0].text)
assert "greyed-out-step" not in selected_hint["class"]
assert selected_hint_text == "The template pulls in the data you provide"
page_content = normalize_spaces(str(page))
assert ("Try sending yourself this example") in page_content
assert "The template pulls in the data you provide" in page_content
assert normalize_spaces(page.select(".sms-message-recipient")[0].text) == (
"To: 202-867-5303"
@@ -303,7 +295,7 @@ def test_back_link_from_first_get_tour_step_points_to_tour_start(
"main.tour_step", service_id=SERVICE_ONE_ID, template_id=fake_uuid, step_index=1
)
assert page.select(".usa-back-link")[0]["href"] == url_for(
assert page.select("nav.usa-breadcrumb a")[0]["href"] == url_for(
"main.begin_tour", service_id=SERVICE_ONE_ID, template_id=fake_uuid
)
@@ -321,7 +313,7 @@ def test_back_link_from_get_tour_step_points_to_previous_step(
"main.tour_step", service_id=SERVICE_ONE_ID, template_id=fake_uuid, step_index=2
)
assert page.select(".usa-back-link")[0]["href"] == url_for(
assert page.select("nav.usa-breadcrumb a")[0]["href"] == url_for(
"main.tour_step", service_id=SERVICE_ONE_ID, template_id=fake_uuid, step_index=1
)
@@ -531,13 +523,9 @@ def test_should_200_for_check_tour_notification(
template_id=fake_uuid,
)
assert normalize_spaces(page.select(".banner-tour .heading-medium")[0].text) == (
"Try sending yourself this example"
)
selected_hint = page.select(".banner-tour .grid-row")[2]
selected_hint_text = normalize_spaces(selected_hint.select(".usa-body")[0].text)
assert "greyed-out-step" not in selected_hint["class"]
assert selected_hint_text == "Notify delivers the message"
page_content = normalize_spaces(str(page))
assert "Try sending yourself this example" in page_content
assert "Notify delivers the message" in page_content
assert normalize_spaces(page.select(".sms-message-recipient")[0].text) == (
"To: 202-867-5303"
@@ -575,7 +563,7 @@ def test_back_link_from_check_tour_notification_points_to_last_tour_step(
template_id=fake_uuid,
)
assert page.select(".usa-back-link")[0]["href"] == url_for(
assert page.select("nav.usa-breadcrumb a")[0]["href"] == url_for(
"main.tour_step", service_id=SERVICE_ONE_ID, template_id=fake_uuid, step_index=3
)