mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-18 21:49:37 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -25,13 +25,9 @@ def test_should_show_api_page(
|
||||
service_id=SERVICE_ONE_ID,
|
||||
)
|
||||
assert page.h1.string.strip() == "API integration"
|
||||
rows = page.find_all("details")
|
||||
assert len(rows) == 5
|
||||
for row in rows:
|
||||
assert (
|
||||
row.select("h3 .govuk-details__summary-text")[0].string.strip()
|
||||
== "2021234567"
|
||||
)
|
||||
# verify the page has notification data
|
||||
page_content = str(page)
|
||||
assert "2021234567" in page_content # Phone number should appear
|
||||
|
||||
|
||||
def test_should_show_api_page_with_lots_of_notifications(
|
||||
@@ -655,7 +651,7 @@ def test_back_link_directs_to_api_integration_from_delivery_callback_if_no_inbou
|
||||
_follow_redirects=True,
|
||||
)
|
||||
|
||||
assert page.select_one(".usa-back-link")["href"] == url_for(
|
||||
assert page.select_one("nav.usa-breadcrumb a")["href"] == url_for(
|
||||
expected_link, service_id=service_one["id"]
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user