mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-17 04:59:37 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
{%- macro govukCheckboxes(params) %}
|
||||
{%- macro usaCheckboxes(params) %}
|
||||
{%- include "./template.njk" -%}
|
||||
{%- endmacro %}
|
||||
{{ govukCheckboxes(params) }}
|
||||
|
||||
{{ usaCheckboxes(params) }}
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
{% from "components/components/error-message/macro.njk" import usaErrorMessage -%}
|
||||
{% from "components/components/fieldset/macro.njk" import govukFieldset %}
|
||||
{% from "components/components/fieldset/macro.njk" import usaFieldset %}
|
||||
{% from "components/components/hint/macro.njk" import usaHint %}
|
||||
{% from "components/components/label/macro.njk" import usaLabel %}
|
||||
|
||||
@@ -7,7 +7,7 @@
|
||||
{#- Updated from GOV.UK components to USWDS patterns
|
||||
Changed from original GOV.UK template:
|
||||
- Uses USWDS checkbox classes (usa-checkbox, usa-checkbox__input, usa-checkbox__label)
|
||||
- Conditional content uses display-none utility class instead of govuk-specific classes
|
||||
- Conditional content uses display-none utility class instead of framework-specific classes
|
||||
- Label uses usaLabel macro instead of radio label
|
||||
- Hint text uses usa-checkbox__label-description class
|
||||
- Maintains all original functionality including conditional reveals and nested checkboxes -#}
|
||||
@@ -129,7 +129,7 @@
|
||||
|
||||
<div class="{% if formGroup %}usa-form-group{% endif %} {%- if params.errorMessage %} usa-form-group--error{% endif %} {%- if params.formGroup.classes %} {{ params.formGroup.classes }}{% endif %}">
|
||||
{% if params.fieldset %}
|
||||
{% call govukFieldset({
|
||||
{% call usaFieldset({
|
||||
describedBy: describedBy,
|
||||
classes: params.fieldset.classes,
|
||||
attributes: params.fieldset.attributes,
|
||||
|
||||
Reference in New Issue
Block a user