mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-19 05:59:44 -04:00
Removed all govuk css (#2814)
* Removed all govuk css * Updated reference files * Removing govuk js * Fixed casing for modules, removed unused page * Got more reference images * Updated template page * Removed govuk padding util * Updated hint to uswds hint * More govuk cleanup * Commiting backstopjs ref files * Fixed all unit tests that broke due to brittleness around govuk styling * Added new ref images * Final removal of govuk * Officially removed all govuk references * Updated reference file * Updated link to button * UI modernization * Cleanup * removed govuk escaping tests since they are no longer needed * Fix CodeQL security issue in escapeElementName function - Escape backslashes first before other special characters - Prevents potential double-escaping vulnerability - Addresses CodeQL alert about improper string escaping * Found more govuk removal. Fixed unit tests * Add missing pipeline check to pre-commit * updated test * Updated e2e test * More update to e2e test * Fixed another e2e test * Simple PR comments addressed * More updates * Updated backstop ref files * Refactored folder selection for non-admins * Updated redundant line * Updated tests to include correct mocks * Added more ref files * Addressing carlos comments * Addressing Carlo comments, cleanup of window initing * More cleanup and addressing carlo comments * Fixing a11 scan * Fixed a few issues with javascript * Fixed for pr * Fixing e2e tests * Tweaking e2e test * Added more ref files and cleaned up urls.js * Fixed bug with creating new template * Removed brittle test - addressed code ql comment * e2e race condition fix * More e2e test fixes * Updated e2e tests to not wait for text sent * Updated test to not wait for button click response * Made tear down more resilent if staging is down * reverted e2e test to what was working before main merge * Updated backstopRef images * Updated gulp to include job-polling differently
This commit is contained in:
@@ -324,7 +324,7 @@ class Service(JSONModel, SortByNameMixin):
|
||||
return self.intending_to_send_email and not self.has_email_reply_to_address
|
||||
|
||||
@property
|
||||
def shouldnt_use_govuk_as_sms_sender(self):
|
||||
def shouldnt_use_default_sms_sender(self):
|
||||
return self.organization_type != Organization.TYPE_FEDERAL
|
||||
|
||||
@cached_property
|
||||
@@ -354,8 +354,8 @@ class Service(JSONModel, SortByNameMixin):
|
||||
return len(self.sms_senders)
|
||||
|
||||
@property
|
||||
def sms_sender_is_govuk(self):
|
||||
return self.default_sms_sender in {"GOVUK", "None"}
|
||||
def sms_sender_is_default(self):
|
||||
return self.default_sms_sender in {"USGOV", "None"}
|
||||
|
||||
def get_sms_sender(self, id):
|
||||
return service_api_client.get_sms_sender(self.id, id)
|
||||
@@ -365,8 +365,8 @@ class Service(JSONModel, SortByNameMixin):
|
||||
return all(
|
||||
(
|
||||
self.intending_to_send_sms,
|
||||
self.shouldnt_use_govuk_as_sms_sender,
|
||||
self.sms_sender_is_govuk,
|
||||
self.shouldnt_use_default_sms_sender,
|
||||
self.sms_sender_is_default,
|
||||
)
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user