Removed all govuk css (#2814)

* Removed all govuk css

* Updated reference files

* Removing govuk js

* Fixed casing for modules, removed unused page

* Got more reference images

* Updated template page

* Removed govuk padding util

* Updated hint to uswds hint

* More govuk cleanup

* Commiting backstopjs ref files

* Fixed all unit tests that broke due to brittleness around govuk styling

* Added new ref images

* Final removal of govuk

* Officially removed all govuk references

* Updated reference file

* Updated link to button

* UI modernization

* Cleanup

* removed govuk escaping tests since they are no longer needed

* Fix CodeQL security issue in escapeElementName function

- Escape backslashes first before other special characters
- Prevents potential double-escaping vulnerability
- Addresses CodeQL alert about improper string escaping

* Found more govuk removal. Fixed unit tests

* Add missing pipeline check to pre-commit

* updated test

* Updated e2e test

* More update to e2e test

* Fixed another e2e test

* Simple PR comments addressed

* More updates

* Updated backstop ref files

* Refactored folder selection for non-admins

* Updated redundant line

* Updated tests to include correct mocks

* Added more ref files

* Addressing carlos comments

* Addressing Carlo comments, cleanup of window initing

* More cleanup and addressing carlo comments

* Fixing a11 scan

* Fixed a few issues with javascript

* Fixed for pr

* Fixing e2e tests

* Tweaking e2e test

* Added more ref files and cleaned up urls.js

* Fixed bug with creating new template

* Removed brittle test - addressed code ql comment

* e2e race condition fix

* More e2e test fixes

* Updated e2e tests to not wait for text sent

* Updated test to not wait for button click response

* Made tear down more resilent if staging is down

* reverted e2e test to what was working before main merge

* Updated backstopRef images

* Updated gulp to include job-polling differently

app/assets/javascripts/preventDuplicateFormSubmissions.js

@@ -11,34 +11,39 @@
 
     $submitButton.data('clicked', 'true');
 
-    // Add dot animation for Send/Schedule/Cancel buttons
+    // Add loading spinner for Send/Schedule/Cancel buttons
     const buttonName = $submitButton.attr('name')?.toLowerCase();
     if (["send", "schedule", "cancel"].includes(buttonName)) {
-      $submitButton.prop('disabled', true);
+      // Use setTimeout with minimal delay to allow form submission to proceed first
+      setTimeout(() => {
+        $submitButton.prop('disabled', true);
 
-      // Inject dot animation span if not already present
-      if ($submitButton.find('.dot-anim').length === 0) {
-        $submitButton.append('<span class="dot-anim" aria-hidden="true"></span>');
-      }
+        // Add loading spinner and aria-busy attribute for accessibility
+        if ($submitButton.find('.loading-spinner').length === 0) {
+          $submitButton.attr('aria-busy', 'true');
+          $submitButton.append('<span class="loading-spinner" role="status" aria-label="Sending"></span>');
+        }
 
-      // Disable Cancel button too
-      const $cancelButton = $('button[name]').filter(function () {
-        return $(this).attr('name')?.toLowerCase() === 'cancel';
-      });
-      $cancelButton.prop('disabled', true);
+        // Disable Cancel button too
+        const $cancelButton = $('button[name]').filter(function () {
+          return $(this).attr('name')?.toLowerCase() === 'cancel';
+        });
+        $cancelButton.prop('disabled', true);
+      }, 50); // Small delay to ensure form submits first
 
       setTimeout(() => {
-        renableSubmitButton($submitButton);
+        renableSubmitButton($submitButton)();
       }, 10000); // fallback safety
     } else {
-      setTimeout(renableSubmitButton($submitButton), 1500);
+      setTimeout(() => renableSubmitButton($submitButton)(), 1500);
     }
   };
 
   const renableSubmitButton = ($submitButton) => () => {
     $submitButton.data('clicked', '');
     $submitButton.prop('disabled', false);
-    $submitButton.find('.dot-anim').remove(); // clean up if needed
+    $submitButton.attr('aria-busy', 'false');
+    $submitButton.find('.loading-spinner').remove(); // clean up spinner
   };
 
   $('form').on('submit', disableSubmitButtons);