darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 18:37:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename test values to clarify they're branding IDs

Browse Source 
In response to: [^1]

[^1]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r832009706
This commit is contained in:
Ben Thorner
2022-03-22 13:02:39 +00:00
parent e7aeb72fd9
commit 6e81d05504
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/app/main/views/test_service_settings.py
+2 -2
View File
@@ -4860,13 +4860,13 @@ def test_email_branding_request_page_shows_branding_if_set(
mocker.patch( mocker.patch(
'app.models.service.Service.email_branding_id', 'app.models.service.Service.email_branding_id',
new_callable=PropertyMock, new_callable=PropertyMock,
return_value='1234-abcd', return_value='some-random-branding',
) )
page = client_request.get( page = client_request.get(
'.email_branding_request', service_id=SERVICE_ONE_ID '.email_branding_request', service_id=SERVICE_ONE_ID
) )
assert page.find('iframe')['src'] == url_for('main.email_template', branding_style='1234-abcd') assert page.find('iframe')['src'] == url_for('main.email_template', branding_style='some-random-branding')
def test_email_branding_request_page_back_link( def test_email_branding_request_page_back_link(
tests/app/utils/test_branding.py
+3 -3
View File
@@ -63,8 +63,8 @@ def test_get_available_choices_service_assigned_to_org(
('govuk_and_org', 'GOV.UK and Test Organisation'), ('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'), ('organisation', 'Test Organisation'),
]), ]),
('1234-abcd', [ ('some-random-branding', [
('govuk', 'GOV.UK'), ('govuk', 'GOV.UK'), # central orgs can switch back to GOV.UK
('govuk_and_org', 'GOV.UK and Test Organisation'), ('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'), ('organisation', 'Test Organisation'),
]) ])
@@ -108,7 +108,7 @@ def test_get_available_choices_letter_branding_set(
mocker.patch( mocker.patch(
'app.models.service.Service.letter_branding_id', 'app.models.service.Service.letter_branding_id',
new_callable=PropertyMock, new_callable=PropertyMock,
return_value='1234-abcd', return_value='some-random-branding',
) )
options = get_available_choices(service, branding_type='letter') options = get_available_choices(service, branding_type='letter')